fix(http): create macrotask during request handling instead of load start. by alan-agius4 · Pull Request #50406 · angular/angular

alan-agius4 · 2023-05-22T14:16:13Z

This commit schedules the macrotask creation to happen before the XHR loadStart event. This is needed as in some cases, Zone.js becomes stable too early.

With this commit, we also update the internal createBackgroundMacroTask method to use Zone.js scheduleMacroTask as otherwise the setTimeout would cause fakeAsync tests to fail due to pending timers.

Closes #50405

…tart This commit schedules the macrotask creation to happen before the XHR `loadStart` event. This is needed as in some cases, Zone.js becomes stable too early. With this commit, we also update the internal `createBackgroundMacroTask` method to use Zone.js `scheduleMacroTask` as otherwise the `setTimeout` would cause `fakeAsync` tests to fail due to pending timers. Closes angular#50405

alan-agius4 · 2023-05-23T14:56:48Z

Caretaker note: G3 failures are pre-existing.

alan-agius4 · 2023-05-23T14:58:50Z

TGP

alan-agius4 · 2023-05-24T14:48:55Z

TGP after de-flaking.

https://fusion2.corp.google.com/OCL:534055856:BASE:534833825:1684939158934:3afcaf79

jessicajaniuk · 2023-05-24T15:33:48Z

This PR was merged into the repository by commit 2cdb4c5.

…tart (#50406) This commit schedules the macrotask creation to happen before the XHR `loadStart` event. This is needed as in some cases, Zone.js becomes stable too early. With this commit, we also update the internal `createBackgroundMacroTask` method to use Zone.js `scheduleMacroTask` as otherwise the `setTimeout` would cause `fakeAsync` tests to fail due to pending timers. Closes #50405 PR Close #50406

…f load start (angular#50406)" This reverts commit 2cdb4c5.

…f load start (#50406)" (#50475) This reverts commit 2cdb4c5. PR Close #50475

…rPendingTasks` This commits refactors the HTTP client to use `InitialRenderPendingTasks` instead of Zone.js macrotask. This is another approach to angular#50406 which was revert due to a failure in G3.

…rPendingTasks` (#50425) This commits refactors the HTTP client to use `InitialRenderPendingTasks` instead of Zone.js macrotask. This is another approach to #50406 which was revert due to a failure in G3. PR Close #50425

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`16.0.2` -> `16.0.4`](https://renovatebot.com/diffs/npm/@angular%2fanimations/16.0.2/16.0.4) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`16.0.2` -> `16.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcommon/16.0.2/16.0.4) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`16.0.2` -> `16.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/16.0.2/16.0.4) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`16.0.2` -> `16.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/16.0.2/16.0.4) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`16.0.2` -> `16.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcore/16.0.2/16.0.4) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`16.0.2` -> `16.0.4`](https://renovatebot.com/diffs/npm/@angular%2fforms/16.0.2/16.0.4) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`16.0.2` -> `16.0.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/16.0.2/16.0.4) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`16.0.2` -> `16.0.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/16.0.2/16.0.4) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v16.0.4`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1604-2023-06-01) [Compare Source](angular/angular@16.0.3...16.0.4) ##### animations | Commit | Type | Description | | -- | -- | -- | | [df65c4fc8f](angular/angular@df65c4f) | fix | Trigger leave animation when ViewContainerRef is injected ([#48705](angular/angular#48705)) | ##### common | Commit | Type | Description | | -- | -- | -- | | [7e1bc513de](angular/angular@7e1bc51) | fix | untrack subscription and unsubscription in async pipe ([#50522](angular/angular#50522)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [9970b29ace](angular/angular@9970b29) | fix | update `ApplicationRef.isStable` to account for rendering pending tasks ([#50425](angular/angular#50425)) |  ### [`v16.0.3`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1603-2023-05-24) [Compare Source](angular/angular@16.0.2...16.0.3) ##### core | Commit | Type | Description | | -- | -- | -- | | [c11041e372](angular/angular@c11041e) | fix | adds missing symbols for animation standalone bundling test ([#50434](angular/angular#50434)) | | [98e8fdf40e](angular/angular@98e8fdf) | fix | fix `Self` flag inside embedded views with custom injectors ([#50270](angular/angular#50270)) | | [199ff4fe7f](angular/angular@199ff4f) | fix | host directives incorrectly validating aliased bindings ([#50364](angular/angular#50364)) | ##### http | Commit | Type | Description | | -- | -- | -- | | [080bbd2137](angular/angular@080bbd2) | fix | create macrotask during request handling instead of load start ([#50406](angular/angular#50406)) |  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1915 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2023-06-24T00:10:00Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

…tart (angular#50406) This commit schedules the macrotask creation to happen before the XHR `loadStart` event. This is needed as in some cases, Zone.js becomes stable too early. With this commit, we also update the internal `createBackgroundMacroTask` method to use Zone.js `scheduleMacroTask` as otherwise the `setTimeout` would cause `fakeAsync` tests to fail due to pending timers. Closes angular#50405 PR Close angular#50406

alan-agius4 added area: common/http Issues related to HTTP and HTTP Client target: patch This PR is targeted for the next patch release labels May 22, 2023

ngbot bot added this to the Backlog milestone May 22, 2023

alan-agius4 added the action: global presubmit The PR is in need of a google3 global presubmit label May 22, 2023

alan-agius4 self-assigned this May 22, 2023

JeanMeche mentioned this pull request May 22, 2023

[BUG]: Using Zone.current.scheduleMacroTask doesn't delay serialization during SSR in v16 #50414

Closed

alan-agius4 force-pushed the http-macro-task branch 2 times, most recently from cff320f to b35e352 Compare May 23, 2023 14:26

alan-agius4 force-pushed the http-macro-task branch 2 times, most recently from 46377b9 to 0ae44ee Compare May 23, 2023 14:31

alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 23, 2023

alan-agius4 requested a review from AndrewKushnir May 23, 2023 14:54

alan-agius4 marked this pull request as ready for review May 23, 2023 14:54

alan-agius4 removed the action: global presubmit The PR is in need of a google3 global presubmit label May 24, 2023

AndrewKushnir approved these changes May 24, 2023

View reviewed changes

alan-agius4 added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 24, 2023

jessicajaniuk added the action: merge The PR is ready for merge by the caretaker label May 24, 2023

jessicajaniuk closed this in 2cdb4c5 May 24, 2023

alan-agius4 deleted the http-macro-task branch May 24, 2023 15:40

dylhunn added a commit to dylhunn/angular that referenced this pull request May 25, 2023

Revert "fix(http): create macrotask during request handling instead o…

4988db7

…f load start (angular#50406)" This reverts commit 2cdb4c5.

dylhunn mentioned this pull request May 25, 2023

Revert "fix(http): create macrotask during request handling instead o… #50475

Closed

14 tasks

dylhunn added a commit that referenced this pull request May 25, 2023

Revert "fix(http): create macrotask during request handling instead o…

6f5dabe

…f load start (#50406)" (#50475) This reverts commit 2cdb4c5. PR Close #50475

dylhunn added a commit that referenced this pull request May 25, 2023

Revert "fix(http): create macrotask during request handling instead o…

1c37a83

…f load start (#50406)" (#50475) This reverts commit 2cdb4c5. PR Close #50475

alan-agius4 mentioned this pull request May 26, 2023

fix(core): update ApplicationRef.isStable to account for rendering pending tasks #50425

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(http): create macrotask during request handling instead of load start.#50406

fix(http): create macrotask during request handling instead of load start.#50406
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:http-macro-task

alan-agius4 commented May 22, 2023

Uh oh!

alan-agius4 commented May 23, 2023

Uh oh!

alan-agius4 commented May 23, 2023 •

edited

Loading

Uh oh!

alan-agius4 commented May 24, 2023

Uh oh!

jessicajaniuk commented May 24, 2023

Uh oh!

angular-automatic-lock-bot bot commented Jun 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

alan-agius4 commented May 22, 2023

Uh oh!

alan-agius4 commented May 23, 2023

Uh oh!

alan-agius4 commented May 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alan-agius4 commented May 24, 2023

Uh oh!

jessicajaniuk commented May 24, 2023

Uh oh!

angular-automatic-lock-bot bot commented Jun 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alan-agius4 commented May 23, 2023 •

edited

Loading