Skip to content

Revert "fix(http): create macrotask during request handling instead o… #50475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dylhunn wants to merge 1 commit into from
Closed

Revert "fix(http): create macrotask during request handling instead o… #50475

dylhunn wants to merge 1 commit into from

Conversation

@dylhunn
Copy link
Contributor

@dylhunn dylhunn commented May 25, 2023

…f load start (#50406)"

This reverts commit 2cdb4c5.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@dylhunn dylhunn added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 25, 2023
@dylhunn dylhunn requested a review from jessicajaniuk May 25, 2023 20:03
@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 25, 2023
@dylhunn
Copy link
Contributor Author

dylhunn commented May 25, 2023

This PR was merged into the repository by commit 6f5dabe.

@dylhunn dylhunn closed this in 6f5dabe May 25, 2023
dylhunn added a commit that referenced this pull request May 25, 2023
@dylhunn
Revert "fix(http): create macrotask during request handling instead o…
1c37a83 
…f load start (#50406)" (#50475)

This reverts commit 2cdb4c5.

PR Close #50475
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 25, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 25, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@dylhunn @ChellappanRajan
Revert "fix(http): create macrotask during request handling instead o…
c3b8cab 
…f load start (angular#50406)" (angular#50475)

This reverts commit 2cdb4c5.

PR Close angular#50475
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dylhunn @jessicajaniuk