fix(common): invalid ImageKit transformation by tanoabeleyra · Pull Request #49201 · angular/angular

tanoabeleyra · 2023-02-25T00:39:01Z

q-auto is an invalid/unsupported transformation and should not be used

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

The ImageLoader for ImageKit is using an invalid/unsupported transformation (q-auto).
Being that I could not find any mention of this transformation in the official documentation, I contacted ImageKit's support and they said:

q-auto while would result in different sizes because of some internal implementations, being an unsupported, undocumented feature, it should not be used in any application.

Issue Number: N/A

What is the new behavior?

The q-auto invalid transformation is not used. Instead, we rely on the default quality value from ImageKit's dashboard, which unless modified is 80 (q-80).

Does this PR introduce a breaking change?

Yes
No

Other information

Unless modified (and if not overwritten via URL), ImageKit applies the following transformations:

Automatic format (f-auto)
Quality = 80 (q-80)

google-cla · 2023-02-25T00:39:05Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

AndrewKushnir · 2023-02-25T01:54:36Z

Hi @khempenius, could you please take a look at this change when you get a chance? Thank you.

AndrewKushnir · 2023-02-25T01:56:31Z

@tanoabeleyra thanks for creating this PR! It looks like you need to sign a CLA (see an auto-generated comment above) before we can proceed with the review. Could you please sign the CLA when you get a chance? Thank you.

tanoabeleyra · 2023-02-25T11:13:10Z

Hi @AndrewKushnir. I already signed the CLA but it failed on the first try because the email was not my primary one.
It seems to be good after pushing the commit once again with the right email. Otherwise, please let me know.

https://github.com/angular/angular/pull/49201/checks?check_run_id=11590617764

AndrewKushnir · 2023-02-27T18:17:30Z

// cc @atcastle

atcastle

LGTM

AndrewKushnir

@tanoabeleyra thanks for improving NgOptimizedImage directive!

q-auto is an invalid/unsupported transformation and should not be used

AndrewKushnir · 2023-03-01T05:13:00Z

Presubmit.

atscott · 2023-03-27T15:33:25Z

This PR was merged into the repository by commit 6499f5a.

q-auto is an invalid/unsupported transformation and should not be used PR Close #49201

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`15.2.4` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fanimations/15.2.4/15.2.5) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`15.2.4` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcommon/15.2.4/15.2.5) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`15.2.4` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/15.2.4/15.2.5) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`15.2.4` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/15.2.4/15.2.5) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`15.2.4` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcore/15.2.4/15.2.5) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`15.2.4` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fforms/15.2.4/15.2.5) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`15.2.4` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/15.2.4/15.2.5) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`15.2.4` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/15.2.4/15.2.5) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v15.2.5`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1525-2023-03-29) [Compare Source](angular/angular@15.2.4...15.2.5) ##### common | Commit | Type | Description | | -- | -- | -- | | [ca5acadb78](angular/angular@ca5acad) | fix | invalid ImageKit transformation ([#49201](angular/angular#49201)) | ##### compiler | Commit | Type | Description | | -- | -- | -- | | [077f6b4674](angular/angular@077f6b4) | fix | do not unquote CSS values ([#49460](angular/angular#49460)) | | [c3cff35869](angular/angular@c3cff35) | fix | handle trailing comma in object literal ([#49535](angular/angular#49535)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [d201fc2dec](angular/angular@d201fc2) | fix | set style property value to empty string instead of an invalid value ([#49460](angular/angular#49460)) | ##### router | Commit | Type | Description | | -- | -- | -- | | [978d37f324](angular/angular@978d37f) | fix | Ensure Router preloading works with lazy component and static children ([#49571](angular/angular#49571)) | | [a844435514](angular/angular@a844435) | fix | fix [#49457](angular/angular#49457) outlet activating with old info ([#49459](angular/angular#49459)) | #### Special Thanks Alan Agius, Andrew Scott, Asaf Malin, Jan Cabadaj, Kristiyan Kostadinov, Matthieu Riegler, Paul Gschwendtner, Sid and Tano Abeleyra  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1842 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2023-04-27T00:08:23Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

pullapprove bot requested a review from atscott February 25, 2023 00:39

AndrewKushnir requested review from AndrewKushnir and removed request for atscott February 25, 2023 01:54

AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release common: image directive area: common Issues related to APIs in the @angular/common package labels Feb 25, 2023

ngbot bot added this to the Backlog milestone Feb 25, 2023

atcastle approved these changes Feb 28, 2023

View reviewed changes

AndrewKushnir approved these changes Mar 1, 2023

View reviewed changes

fix(common): invalid ImageKit transformation

20feed0

q-auto is an invalid/unsupported transformation and should not be used

AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 1, 2023

angular-robot bot requested a review from AndrewKushnir March 1, 2023 05:11

AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Mar 27, 2023

AndrewKushnir approved these changes Mar 27, 2023

View reviewed changes

atscott pushed a commit that referenced this pull request Mar 27, 2023

fix(common): invalid ImageKit transformation (#49201)

ca5acad

q-auto is an invalid/unsupported transformation and should not be used PR Close #49201

atscott closed this in 6499f5a Mar 27, 2023

angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(common): invalid ImageKit transformation#49201

fix(common): invalid ImageKit transformation#49201
tanoabeleyra wants to merge 1 commit intoangular:mainfrom
tanoabeleyra:fix-imagekit-loader

tanoabeleyra commented Feb 25, 2023

Uh oh!

google-cla bot commented Feb 25, 2023

Uh oh!

AndrewKushnir commented Feb 25, 2023

Uh oh!

AndrewKushnir commented Feb 25, 2023 •

edited

Loading

Uh oh!

tanoabeleyra commented Feb 25, 2023 •

edited

Loading

Uh oh!

AndrewKushnir commented Feb 27, 2023

Uh oh!

atcastle left a comment

Uh oh!

AndrewKushnir left a comment

Uh oh!

AndrewKushnir commented Mar 1, 2023

Uh oh!

atscott commented Mar 27, 2023

Uh oh!

angular-automatic-lock-bot bot commented Apr 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

tanoabeleyra commented Feb 25, 2023

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

google-cla bot commented Feb 25, 2023

Uh oh!

AndrewKushnir commented Feb 25, 2023

Uh oh!

AndrewKushnir commented Feb 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tanoabeleyra commented Feb 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndrewKushnir commented Feb 27, 2023

Uh oh!

atcastle left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir commented Mar 1, 2023

Uh oh!

atscott commented Mar 27, 2023

Uh oh!

angular-automatic-lock-bot bot commented Apr 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AndrewKushnir commented Feb 25, 2023 •

edited

Loading

tanoabeleyra commented Feb 25, 2023 •

edited

Loading