Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: angular/angular
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 15.2.4
Choose a base ref
...
head repository: angular/angular
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 15.2.5
Choose a head ref
  • 14 commits
  • 46 files changed
  • 11 contributors

Commits on Mar 22, 2023

  1. fix(router): fix #49457 outlet activating with old info (#49459)

    Avoid activating outlet with old info if route was changed before outlet activated
    
    PR Close #49459
    jancabadaj authored and atscott committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    a844435 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. fix(compiler): handle trailing comma in object literal (#49535)

    Fixes that the compiler wasn't parsing an object literal with a trailing comma correctly.
    
    Fixes #49534.
    
    PR Close #49535
    crisbeto authored and atscott committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    c3cff35 View commit details
    Browse the repository at this point in the history
  2. docs: add missing word (#49565)

    I have added a word to make the sentence more meaningful.
    PR Close #49565
    hugo-sid authored and atscott committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    3f8e4fb View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Configuration menu
    Copy the full SHA
    29c682c View commit details
    Browse the repository at this point in the history
  2. build: update actions/checkout digest to 8f4b7f8 (#49577)

    See associated pull request for more information.
    
    PR Close #49577
    angular-robot authored and atscott committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    656a388 View commit details
    Browse the repository at this point in the history
  3. fix(router): Ensure Router preloading works with lazy component and s…

    …tatic children (#49571)
    
    The preloading strategy did not handle a `loadComponent` on a route with
    a static `children`. It only preloaded children if they were also
    `loadChildren` or both were not lazy loaded.
    
    fixes #49558
    
    PR Close #49571
    atscott committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    978d37f View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. fix(common): invalid ImageKit transformation (#49201)

    q-auto is an invalid/unsupported transformation and should not be used
    
    PR Close #49201
    tanoabeleyra authored and atscott committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    ca5acad View commit details
    Browse the repository at this point in the history
  2. ci: update pullapprove config to reflect current availability (#49592)

    Updating PullApprove to reflect current availability. Looks like it cannot be set via UI anymore...
    PR Close #49592
    devversion authored and atscott committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    0fecbab View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. refactor(common): add missing override to satisfy the linter (#49599)

    Linter was complaining of missing `override` despite being OK on the CI. this commits add them.
    
    PR Close #49599
    JeanMeche authored and atscott committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    4c89a24 View commit details
    Browse the repository at this point in the history
  2. docs: fixed grammar (#49560)

    PR Close #49560
    Asaf-Malin authored and atscott committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    8ed4083 View commit details
    Browse the repository at this point in the history
  3. refactor(core): Remove usage of deprecated Injector.create() (#49606)

    This commit removes all usages of the deprecated `Injector.create` method but does not remove the deprecated signature itself.
    
    PR Close #49606
    JeanMeche authored and atscott committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    6d6fc12 View commit details
    Browse the repository at this point in the history
  4. fix(core): set style property value to empty string instead of an inv…

    …alid value (#49460)
    
    Currently when the value of a styling property that has a unit is empty string a invalid value is generated.
    
    Example:
    `[style.width.px] = ""` will generate a value of `"px"`, when instead it should be `""`.
    
    This causes browser to reset the value to an empty string. This is however not the case in Domino with changes in angular/domino@bfc9114.
    
    This commit fixes the issues and generate correct values.
    
    PR Close #49460
    alan-agius4 authored and atscott committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    d201fc2 View commit details
    Browse the repository at this point in the history
  5. fix(compiler): do not unquote CSS values (#49460)

    Currently we are unsafely unquoting CSS values which in some cases causes valid values to become invalid and invalid values to become valid.
    
    Example:
    ```html
    <div style="width:&quot;1px;&quot;"></div>
    ```
    
    In the above case, `width` has an invalid value of `"1px"`, however the compiler will transform it to `1px` which makes it valid.
    
    On the other hand,  in the below case
    ```html
    <div style="content:&quot;foo&quot;"></div>
    ```
    
    `content` has a valid value of `"foo"`, but since the compiler unwraps it to `foo` it becomes invalid. For correctness, we should not remove quotes.
    
    ```js
    const div = document.createElement('div');
    div.style.width='"1px"';
    div.style.content='foo';
    
    div.style.width; // ''
    div.style.content; // ''
    
    div.style.width='1px';
    div.style.content='"foo"';
    
    div.style.width; // '1px'
    div.style.content; // '"foo"'
    ```
    
    More information about values can be found https://www.w3.org/TR/CSS21/syndata.html#value-def-identifier
    
    PR Close #49460
    alan-agius4 authored and atscott committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    077f6b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Configuration menu
    Copy the full SHA
    e78a2a4 View commit details
    Browse the repository at this point in the history
Loading