refactor(common): add missing override to satisfy the linter#49599
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
refactor(common): add missing override to satisfy the linter#49599JeanMeche wants to merge 1 commit intoangular:mainfrom
override to satisfy the linter#49599JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
Linter was complaining of missing `override` despite being OK on the CI. this commits add them.
AndrewKushnir
approved these changes
Mar 28, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@JeanMeche thanks a lot for the cleanup 👍
Contributor
@JeanMeche it's likely that we run lint on CI for changed files only. |
Contributor
Contributor
|
Caretaker notes:
|
Contributor
|
This PR was merged into the repository by commit f305f22. |
atscott
pushed a commit
that referenced
this pull request
Mar 28, 2023
Linter was complaining of missing `override` despite being OK on the CI. this commits add them. PR Close #49599
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
yarn lintlocally, the linter was complaining for several missingoverrideAny idea why ?Anyway, here are the fixes for the complaints, they were in common, compiler and platform-browser.