Conversation
... as WP Core has renamed the parameter as part of the efforts to become compatible with PHP 8.0. Ref: WordPress/wordpress-develop@51fae8b
... to be in line with the parameter name as used by WP Core for optimal compatibility with PHP 8.0. Ref: https://developer.wordpress.org/reference/functions/wp_parse_args/
1 similar comment
Collaborator
Author
|
FYI: similar changes have been pulled to BrainMonkey itself and are expected to be included in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BrainMonkey/YoastTestCase: rename parameter for mocked function
... as WP Core has renamed the parameter as part of the efforts to become compatible with PHP 8.0.
Ref: WordPress/wordpress-develop@51fae8b
BrainMonkey/YoastTestCase: rename parameter for mocked function
... to be in line with the parameter name as used by WP Core for optimal compatibility with PHP 8.0.
Ref: https://developer.wordpress.org/reference/functions/wp_parse_args/