WP Helper functions: ensure parameter names are in line with WP Core#136
Merged
WP Helper functions: ensure parameter names are in line with WP Core#136
Conversation
... for compatibility with code under test using PHP 8.0+ function calls with named arguments. For some of these functions, WP has renamed the parameter(s) over the past year or so, for some, the names were never in line. Even though WP Core doesn't necessarily officially _support_ the use of named parameters in function calls, that (of course) won't stop people from using them and their tests should not break on that due to BrainMonkey not being in line with WP for parameter names.
gmazzap
approved these changes
May 1, 2023
Contributor
|
Thank you @jrfnl! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... for compatibility with code under test using PHP 8.0+ function calls with named arguments.
For some of these functions, WP has renamed the parameter(s) over the past year or so, for some, the names were never in line.
Even though WP Core doesn't necessarily officially support the use of named parameters in function calls, that (of course) won't stop people from using them and their tests should not break on that due to BrainMonkey not being in line with WP for parameter names.