✨ Added more card types to the welcome email editor, like images by EvanHahn · Pull Request #26645 · TryGhost/Ghost

EvanHahn · 2026-03-02T16:55:45Z

closes https://linear.app/ghost/issue/NY-1104

Moved the welcomeEmailEditor feature flag to GA.

coderabbitai · 2026-03-02T16:55:58Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4d5634f5-d29f-4640-8c7d-4dea2b71025a

📥 Commits

Reviewing files that changed from the base of the PR and between b012384 and b766287.

⛔ Files ignored due to path filters (1)

ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap is excluded by !**/*.snap

📒 Files selected for processing (1)

ghost/core/core/shared/labs.js

🚧 Files skipped from review as they are similar to previous changes (1)

ghost/core/core/shared/labs.js

Walkthrough

The "Welcome Email Editor" feature flag was moved from private/experimental to general availability. It was removed from the private features list and added to the GA features set, resulting in it being enabled by default and removed from the private writable keys allowlist. No other logic or rendering changes were made.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title mentions adding card types to the welcome email editor, but the changeset only moves the feature flag to GA and removes it from private features—no new card types are actually added.	Update the title to accurately reflect the main change: moving welcomeEmailEditor feature flag to GA, such as '🚀 Move welcomeEmailEditor feature flag to GA'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description correctly mentions moving the welcomeEmailEditor feature flag to GA, which aligns with the actual changeset in the code files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch ny-1104-welcomeemaileditor-ga

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

ErisDS · 2026-03-02T17:25:14Z

🤖 Velo CI Failure Analysis

Classification: 🟠 SOFT FAIL

Workflow: CI
Failed Step: E2E tests
Run: View failed run
What failed: Test snapshot mismatch for Stripe settings edit
Why: The root cause is a test assertion failure where the response headers from the Stripe settings edit endpoint do not match the expected snapshot. This is a code issue, as the test is validating the application's behavior.
Action:
The developer should investigate the Stripe settings edit functionality and update the test snapshot to match the expected response headers.

closes https://linear.app/ghost/issue/NY-1104 Moved the `welcomeEmailEditor` feature flag to GA.

coderabbitai

🧹 Nitpick comments (1)

ghost/core/core/shared/labs.js (1)
28-29: Consider adding a regression test for GA-vs-writable behavior.

Since this flag moved to GA, add coverage that labs.getAll().welcomeEmailEditor === true while writes/imports for labs.welcomeEmailEditor are ignored via WRITABLE_KEYS_ALLOWLIST filtering. This will prevent accidental reintroduction as writable later.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@ghost/core/core/shared/labs.js` around lines 28 - 29, Add a regression test
that asserts the GA-only flag behavior: call labs.getAll() and assert
welcomeEmailEditor === true, then attempt to write/update/import
labs.welcomeEmailEditor and assert that the value remains unchanged (writes are
ignored) because WRITABLE_KEYS_ALLOWLIST prevents mutation; specifically test
both direct writes via the labs setter/update API and import flows to confirm
WRITABLE_KEYS_ALLOWLIST filtering is applied to welcomeEmailEditor and that
labs.getAll() still returns true afterward. Ensure the test references
labs.getAll(), labs setter/update/import methods used in your codebase, and
WRITABLE_KEYS_ALLOWLIST so it will catch any accidental reintroduction of
welcomeEmailEditor as writable.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@ghost/core/core/shared/labs.js`:
- Around line 28-29: Add a regression test that asserts the GA-only flag
behavior: call labs.getAll() and assert welcomeEmailEditor === true, then
attempt to write/update/import labs.welcomeEmailEditor and assert that the value
remains unchanged (writes are ignored) because WRITABLE_KEYS_ALLOWLIST prevents
mutation; specifically test both direct writes via the labs setter/update API
and import flows to confirm WRITABLE_KEYS_ALLOWLIST filtering is applied to
welcomeEmailEditor and that labs.getAll() still returns true afterward. Ensure
the test references labs.getAll(), labs setter/update/import methods used in
your codebase, and WRITABLE_KEYS_ALLOWLIST so it will catch any accidental
reintroduction of welcomeEmailEditor as writable.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 41c99e80-3dd5-4175-a670-85c9b67c6b44

📥 Commits

Reviewing files that changed from the base of the PR and between 6587347 and b012384.

⛔ Files ignored due to path filters (1)

ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap is excluded by !**/*.snap

📒 Files selected for processing (2)

apps/admin-x-settings/src/components/settings/advanced/labs/private-features.tsx
ghost/core/core/shared/labs.js

💤 Files with no reviewable changes (1)

apps/admin-x-settings/src/components/settings/advanced/labs/private-features.tsx

EvanHahn force-pushed the ny-1104-welcomeemaileditor-ga branch from b3e6e82 to c3075f1 Compare March 4, 2026 17:02

✨ Added more card types to the welcome email editor, like images

b012384

closes https://linear.app/ghost/issue/NY-1104 Moved the `welcomeEmailEditor` feature flag to GA.

EvanHahn force-pushed the ny-1104-welcomeemaileditor-ga branch from c3075f1 to b012384 Compare March 4, 2026 22:53

EvanHahn marked this pull request as ready for review March 4, 2026 23:21

coderabbitai bot reviewed Mar 4, 2026

View reviewed changes

EvanHahn requested a review from 9larsons March 5, 2026 11:28

9larsons approved these changes Mar 5, 2026

View reviewed changes

Merge branch 'main' into ny-1104-welcomeemaileditor-ga

b766287

9larsons enabled auto-merge (squash) March 5, 2026 15:40

9larsons merged commit bc692dc into main Mar 5, 2026
31 checks passed

9larsons deleted the ny-1104-welcomeemaileditor-ga branch March 5, 2026 15:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

✨ Added more card types to the welcome email editor, like images#26645

✨ Added more card types to the welcome email editor, like images#26645
9larsons merged 2 commits intomainfrom
ny-1104-welcomeemaileditor-ga

EvanHahn commented Mar 2, 2026

Uh oh!

coderabbitai bot commented Mar 2, 2026 •

edited

Loading

❌ Failed checks (1 warning)

Uh oh!

ErisDS commented Mar 2, 2026

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

EvanHahn commented Mar 2, 2026

Uh oh!

coderabbitai bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

❌ Failed checks (1 warning)

Uh oh!

ErisDS commented Mar 2, 2026

🤖 Velo CI Failure Analysis

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Mar 2, 2026 •

edited

Loading