Add `delete_self_hosted_runner` to `Organization` #3306

uncleDecart · 2025-06-24T15:47:08Z

PR related to #3189

This PR introduces a new function delete_self_hosted_runner to handle the deletion of self-hosted runners at the organization level.
Additionally, it includes a documentation update to correct the description of the get_self_hosted_runners function.

For guidance on tests, I referred to PRs #3190 and #3203 (huge thanks to @climbfuji and @billnapier)

Previous link was for runner groups, not runners of organization. Endpoint was specified correctly Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>

uncleDecart · 2025-06-24T15:49:21Z

I can’t assign reviewers here, but judging by #3190, I kindly request @Felixoid for a review. :)

Felixoid

Looks good to me

uncleDecart · 2025-06-26T15:13:04Z

I've found a typo in request url, fixed it

uncleDecart · 2025-06-27T08:08:25Z

Added missing accept header

uncleDecart · 2025-07-13T19:02:27Z

@EnricoMi is there anything blocking us from merging this PR?

EnricoMi · 2025-07-15T11:10:15Z

github/Organization.py

            list_item="runners",
        )

+    def delete_self_hosted_runner(self, runner_id: str) -> PaginatedList[SelfHostedActionsRunner]:


Suggested change

def delete_self_hosted_runner(self, runner_id: str) -> PaginatedList[SelfHostedActionsRunner]:

def delete_self_hosted_runner(self, runner_id: str) -> None:

great catch! Thank you, fixed

EnricoMi · 2025-07-15T11:10:35Z

tests/Organization.py

        self.assertEqual(runners.totalCount, 602)

+    def testDeleteSelfHostedRunner(self):
+        runners = self.org.delete_self_hosted_runner("42")


Suggested change

runners = self.org.delete_self_hosted_runner("42")

self.org.delete_self_hosted_runner("42")

great catch, fixed, thanks!

This is part of PyGithub#3189 Does not implement the whole functionality, just a specific function which I need Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>

uncleDecart · 2025-07-24T14:29:33Z

@EnricoMi is there anything else blocking this PR?

EnricoMi

LGTM!

github-actions · 2025-07-30T20:50:07Z

Test Results

8 files ± 0 8 suites ±0 4m 48s ⏱️ -4s
1 009 tests + 10 1 009 ✅ + 10 0 💤 ±0 0 ❌ ±0
11 147 runs +3 155 11 146 ✅ +3 155 1 💤 ±0 0 ❌ ±0

Results for commit 8a34996. ± Comparison against base commit b4092b5.

♻️ This comment has been updated with latest results.

@climbfuji

PR related to PyGithub#3189 This PR introduces a new function `delete_self_hosted_runner` to handle the deletion of self-hosted runners at the organization level. Additionally, it includes a documentation update to correct the description of the `get_self_hosted_runners` function. For guidance on tests, I referred to PRs PyGithub#3190 and PyGithub#3203 (huge thanks to @climbfuji and @billnapier) --------- Signed-off-by: Pavel Abramov <uncle.decart@gmail.com> Co-authored-by: Enrico Minack <github@enrico.minack.dev>

Use correct documentation link for self-hosted runners

f25daed

Previous link was for runner groups, not runners of organization. Endpoint was specified correctly Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>

billnapier approved these changes Jun 24, 2025

View reviewed changes

Felixoid approved these changes Jun 25, 2025

View reviewed changes

uncleDecart force-pushed the remove-runner branch from 011d03d to 2857392 Compare June 26, 2025 15:12

uncleDecart force-pushed the remove-runner branch from 2857392 to bb51888 Compare June 27, 2025 08:07

EnricoMi requested changes Jul 15, 2025

View reviewed changes

EnricoMi changed the title ~~Add delete_self_hosted_runner for org level; fix documentation for get_self_hosted_runners~~ Add delete_self_hosted_runner to Organization Jul 15, 2025

Add funciton to delete self-hosted runner at org level

5328c63

This is part of PyGithub#3189 Does not implement the whole functionality, just a specific function which I need Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>

uncleDecart force-pushed the remove-runner branch from bb51888 to 5328c63 Compare July 15, 2025 11:23

EnricoMi approved these changes Jul 30, 2025

View reviewed changes

Fix replay data

8a34996

EnricoMi added this pull request to the merge queue Jul 31, 2025

Merged via the queue into PyGithub:main with commit cb42815 Jul 31, 2025
22 checks passed

EnricoMi added the improvement label Jul 31, 2025

	def delete_self_hosted_runner(self, runner_id: str) -> PaginatedList[SelfHostedActionsRunner]:
	def delete_self_hosted_runner(self, runner_id: str) -> None:

	runners = self.org.delete_self_hosted_runner("42")
	self.org.delete_self_hosted_runner("42")

Uh oh!

Add delete_self_hosted_runner to Organization #3306

Add delete_self_hosted_runner to Organization #3306

Uh oh!

Conversation

uncleDecart commented Jun 24, 2025

Uh oh!

uncleDecart commented Jun 24, 2025

Uh oh!

Felixoid left a comment

Choose a reason for hiding this comment

Uh oh!

uncleDecart commented Jun 26, 2025

Uh oh!

uncleDecart commented Jun 27, 2025

Uh oh!

uncleDecart commented Jul 13, 2025

Uh oh!

EnricoMi Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

uncleDecart Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

EnricoMi Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

uncleDecart Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

uncleDecart commented Jul 24, 2025

Uh oh!

EnricoMi left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add `delete_self_hosted_runner` to `Organization` #3306

Add `delete_self_hosted_runner` to `Organization` #3306

github-actions bot commented Jul 30, 2025 •

edited

Loading