Skip to content

fix: manage the space between operator and version on Composer JSON reader#9203

Merged
kubawerlos merged 3 commits intoPHP-CS-Fixer:masterfrom
misaert:fix-composer-json-reader-min-ser-ver
Nov 15, 2025
Merged

fix: manage the space between operator and version on Composer JSON reader#9203
kubawerlos merged 3 commits intoPHP-CS-Fixer:masterfrom
misaert:fix-composer-json-reader-min-ser-ver

Conversation

@misaert
Copy link
Copy Markdown
Contributor

@misaert misaert commented Nov 13, 2025 •
edited
Loading

Before this PR, the constraint for PHP >= 8.2 did throw an exception UnexpectedValueException with the message Invalid version string "".

Exception:

^ UnexpectedValueException {#1496
 #message: "Invalid version string """
 #code: 0
 #file: "./vendor/composer/semver/src/VersionParser.php"
 #line: 191
 trace: {
   ./vendor/composer/semver/src/VersionParser.php:191 { …}
   ./vendor/composer/semver/src/Semver.php:104 { …}
   ./vendor/composer/semver/src/Semver.php:71 { …}
   ./vendor/friendsofphp/php-cs-fixer/src/ComposerJsonReader.php:125 { …}
   ./vendor/friendsofphp/php-cs-fixer/src/ComposerJsonReader.php:88 { …}
   ./vendor/friendsofphp/php-cs-fixer/src/ComposerJsonReader.php:77 { …}
   ./vendor/friendsofphp/php-cs-fixer/src/ComposerJsonReader.php:50 { …}
   ./vendor/friendsofphp/php-cs-fixer/src/Console/WarningsDetector.php:76 { …}
   ./vendor/friendsofphp/php-cs-fixer/src/Console/Application.php:105 { …}
   ./vendor/symfony/console/Application.php:195 { …}
   ./vendor/friendsofphp/php-cs-fixer/php-cs-fixer:110 { …}
   ./vendor/bin/php-cs-fixer:118 { …}
 }
}

The issue is the space between the operators and the PHP version. It is ok for Composer so I guess we have to manage it.

I see it with the message Unable to determine minimum supported PHP version from composer.json: Invalid version string "" from this related PR:

@misaert misaert changed the title fix: manage the space between operator and version on composer JSON reader fix: manage the space between operator and version on Composer JSON reader Nov 13, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 13, 2025 •
edited
Loading

Coverage Status

coverage: 93.768%. remained the same
when pulling 601008d on misaert:fix-composer-json-reader-min-ser-ver
into cad3e9b on PHP-CS-Fixer:master.

keradus
keradus reviewed Nov 13, 2025
View reviewed changes
Comment thread tests/ComposerJsonReaderTest.php
keradus
keradus approved these changes Nov 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@keradus keradus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix

@kubawerlos kubawerlos merged commit 03a866d into PHP-CS-Fixer:master Nov 15, 2025
32 checks passed
@kubawerlos
Copy link
Copy Markdown
Member

kubawerlos commented Nov 15, 2025

Thank you @misaert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keradus keradus keradus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@misaert @coveralls @kubawerlos @keradus