Skip to content

UX: Warn if executed php version is higher than the minimum php version defined in composer.json#9134

Merged
keradus merged 22 commits intoPHP-CS-Fixer:masterfrom
mbolli:php-version-warning
Oct 14, 2025
Merged

UX: Warn if executed php version is higher than the minimum php version defined in composer.json#9134
keradus merged 22 commits intoPHP-CS-Fixer:masterfrom
mbolli:php-version-warning

Conversation

@mbolli
Copy link
Copy Markdown
Contributor

@mbolli mbolli commented Oct 8, 2025

might fix #9133
might fix #7312

image

@mbolli mbolli mentioned this pull request Oct 8, 2025
Closed
@coveralls
Copy link
Copy Markdown

coveralls commented Oct 8, 2025 •
edited
Loading

Coverage Status

coverage: 94.161% (+0.01%) from 94.148%
when pulling 5d01da1 on mbolli:php-version-warning
into b6adb6e on PHP-CS-Fixer:master.

@Wirone Wirone added the tests required PR does not have tests and it's a blocker for further processing label Oct 8, 2025
Wirone
Wirone previously requested changes Oct 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Wirone Wirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want this PR be considered for merging, you need to provide tests that show it works as expected. Yes, it may be tricky in this case, but maybe doable. Did you skip them deliberately?

keradus
keradus reviewed Oct 9, 2025
View reviewed changes
keradus
keradus reviewed Oct 9, 2025
View reviewed changes
keradus
keradus reviewed Oct 9, 2025
View reviewed changes
keradus
keradus reviewed Oct 9, 2025
View reviewed changes
keradus
keradus reviewed Oct 9, 2025
View reviewed changes
@mbolli @keradus
update warning message
71de3ec 
Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com>
keradus
keradus reviewed Oct 9, 2025
View reviewed changes
keradus
keradus reviewed Oct 9, 2025
View reviewed changes
keradus
keradus reviewed Oct 9, 2025
View reviewed changes
keradus
keradus reviewed Oct 9, 2025
View reviewed changes
keradus
keradus reviewed Oct 9, 2025
View reviewed changes
mbolli and others added 4 commits October 9, 2025 13:26
@mbolli @keradus
update warning message
fb97b9b 
Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com>
@mbolli @keradus
update warning message if reading from composer.json fails
c793b7a 
Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com>
@mbolli
review fixes
4d9b775
@mbolli
fix cs
cf82dd2
keradus
keradus reviewed Oct 9, 2025
View reviewed changes
keradus
keradus reviewed Oct 9, 2025
View reviewed changes
@keradus keradus requested a review from Wirone October 9, 2025 12:03
keradus
keradus reviewed Oct 9, 2025
View reviewed changes
keradus
keradus reviewed Oct 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/ looks OK for me,
eager to hear @Wirone's input , as he was concerned on tests/

Wirone
Wirone reviewed Oct 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Wirone Wirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not dig really deep into these tests, but from first glance they look OK. Leaving some minor feedback, @keradus feel free to continue without my approval.

keradus
keradus reviewed Oct 13, 2025
View reviewed changes
keradus
keradus reviewed Oct 13, 2025
View reviewed changes
keradus
keradus reviewed Oct 13, 2025
View reviewed changes
keradus
keradus reviewed Oct 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@keradus keradus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good so far.

  • added few suggestions for tests improvements
  • please update the smoke tests, as CI is failing

@keradus keradus changed the title Warn if executed php version is higher than the minimum php version defined in composer.json UX: Warn if executed php version is higher than the minimum php version defined in composer.json Oct 13, 2025
@mbolli mbolli changed the title UX: Warn if executed php version is higher than the minimum php version defined in composer.json DX: Warn if executed php version is higher than the minimum php version defined in composer.json Oct 14, 2025
@keradus keradus changed the title DX: Warn if executed php version is higher than the minimum php version defined in composer.json UX: Warn if executed php version is higher than the minimum php version defined in composer.json Oct 14, 2025
@keradus keradus dismissed Wirone’s stale review October 14, 2025 19:17

Dismiss review due to #9134 (review)

keradus
keradus approved these changes Oct 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you

@keradus keradus enabled auto-merge (squash) October 14, 2025 19:18
@keradus keradus merged commit 3c1eb9e into PHP-CS-Fixer:master Oct 14, 2025
31 of 32 checks passed
@kubawerlos kubawerlos mentioned this pull request Nov 12, 2025
Closed
2 tasks
@keradus keradus mentioned this pull request Nov 13, 2025
Merged
@misaert misaert mentioned this pull request Nov 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wirone Wirone Wirone left review comments

@keradus keradus keradus approved these changes

Assignees

No one assigned

Labels

tests required PR does not have tests and it's a blocker for further processing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use PHP version from composer.json/command flag vs. PHP_VERSION_ID

4 participants

@mbolli @coveralls @Wirone @keradus