Use DecompressionStream when available#1971
Merged
FrederikBolding merged 8 commits intomainfrom Dec 4, 2023
Merged
Conversation
f836f41 to
743a351
Compare
743a351 to
b7eac07
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1971 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 267 267
Lines 6230 6240 +10
Branches 1007 1009 +2
=======================================
+ Hits 5986 5996 +10
Misses 244 244 ☔ View full report in Codecov by Sentry. |
DecompressionStream when available
Mrtenz
approved these changes
Dec 4, 2023
FrederikBolding
added a commit
that referenced
this pull request
Dec 19, 2023
Following the merge of #1971 we saw increased failures when fetching snaps. We haven't been able to fully understand why yet, but it looks like it may be a race condition in some of the stream code. Out of caution, we revert part of the PR to stop using `DecompressionStream` for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the NPM unpacking implementation slightly to use native browser
DecompressionStreamfor gzip decompression, where possible. If not possible, we usebrowserify-zlibinstead ofgunzip-maybeas it is slightly faster.Also adds a header to the NPM manifest fetching code that strips a bunch of unnecessary information.