Revert usage of DecompressionStream#2052
Merged
FrederikBolding merged 2 commits intomainfrom Dec 19, 2023
Merged
Conversation
Mrtenz
previously approved these changes
Dec 19, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2052 +/- ##
=======================================
Coverage 96.22% 96.23%
=======================================
Files 270 271 +1
Lines 6310 6313 +3
Branches 1023 1022 -1
=======================================
+ Hits 6072 6075 +3
Misses 238 238 ☔ View full report in Codecov by Sentry. |
Mrtenz
approved these changes
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the merge of #1971 we saw increased failures when fetching snaps. We haven't been able to fully understand why yet, but it looks like it may be a race condition in some of the stream code. Out of caution, we revert part of the PR to stop using
DecompressionStreamfor now.