Skip to content

Add useTransactionSimulations preference#4283

Merged
OGPoyraz merged 2 commits intomainfrom
1720-add-privacy-toggle-to-disable-simulations
May 17, 2024
Merged

Add useTransactionSimulations preference#4283
OGPoyraz merged 2 commits intomainfrom
1720-add-privacy-toggle-to-disable-simulations

Conversation

@OGPoyraz
Copy link
Copy Markdown
Member

Explanation

This PR goal is to add useTransactionSimulations to PreferencesController

References

Changelog

@metamask/preferences-controller

  • ADDED: Add useTransactionSimulations preference

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@OGPoyraz OGPoyraz added the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label May 16, 2024
@OGPoyraz OGPoyraz requested a review from a team May 16, 2024 10:31
@OGPoyraz OGPoyraz added team-confirmations and removed team-confirmations-system DEPRECATED: please use "team-confirmations" label instead labels May 16, 2024
@OGPoyraz OGPoyraz merged commit da3b931 into main May 17, 2024
@OGPoyraz OGPoyraz deleted the 1720-add-privacy-toggle-to-disable-simulations branch May 17, 2024 09:20
OGPoyraz added a commit to MetaMask/metamask-mobile that referenced this pull request Jun 6, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR goal is to add upcoming transaction simulations toggle to
security preferences.

Note: Toggle currently hidden behind a feature flag env which we aim to
remove this week and enable.
Patched part of the preferences controller already applied to main here
MetaMask/core#4283

## **Related issues**

Fixes: MetaMask/mobile-planning#1720

## **Manual testing steps**

1. Security settings, toggle off "Estimated balance changes"
2. Close app
3. Open app and see if it still toggled off (also validate opposite to
make sure `PreferencesController` updates accordingly)


## **Screenshots/Recordings**


https://github.com/MetaMask/metamask-mobile/assets/7644512/cc197830-3874-475c-95d4-a9d79884f7f7

## **Pre-merge author checklist**

- [X] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants