feat: add transaction simulations preference#9648
Merged
Conversation
digiwand
previously approved these changes
May 28, 2024
Contributor
digiwand
left a comment
There was a problem hiding this comment.
LGTM!
one question to learn a bit more
27a1a7d to
944ead6
Compare
app/components/Views/Settings/SecuritySettings/SecuritySettings.tsx
Outdated
Show resolved
Hide resolved
app/components/Views/Settings/SecuritySettings/SecuritySettings.tsx
Outdated
Show resolved
Hide resolved
app/components/Views/Settings/SecuritySettings/SecuritySettings.tsx
Outdated
Show resolved
Hide resolved
matthewwalsh0
previously approved these changes
Jun 3, 2024
7 tasks
vinistevam
previously approved these changes
Jun 4, 2024
jpuri
reviewed
Jun 4, 2024
digiwand
previously approved these changes
Jun 4, 2024
digiwand
reviewed
Jun 4, 2024
tommasini
reviewed
Jun 5, 2024
app/components/Views/Settings/SecuritySettings/SecuritySettings.tsx
Outdated
Show resolved
Hide resolved
tommasini
reviewed
Jun 5, 2024
tommasini
previously approved these changes
Jun 5, 2024
vinistevam
previously approved these changes
Jun 5, 2024
Contributor
|
|
Contributor
|
tommasini
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR goal is to add upcoming transaction simulations toggle to security preferences.
Note: Toggle currently hidden behind a feature flag env which we aim to remove this week and enable.
Patched part of the preferences controller already applied to main here MetaMask/core#4283
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/1720
Manual testing steps
PreferencesControllerupdates accordingly)Screenshots/Recordings
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-05-16.at.12.44.55.mp4
Pre-merge author checklist
Pre-merge reviewer checklist