Add support for more events - schedule, workflow_dispatch, workflow_run#145
Merged
Conversation
instrap
approved these changes
Sep 20, 2024
MMcM
added a commit
to MMcM/fdb-record-layer
that referenced
this pull request
Feb 7, 2025
MMcM
added a commit
to MMcM/fdb-record-layer
that referenced
this pull request
Feb 7, 2025
MMcM
added a commit
to MMcM/fdb-record-layer
that referenced
this pull request
Feb 11, 2025
MMcM
added a commit
to MMcM/fdb-record-layer
that referenced
this pull request
Feb 12, 2025
alecgrieser
pushed a commit
to FoundationDB/fdb-record-layer
that referenced
this pull request
Feb 12, 2025
* Split out the PR coverage commenting workflow so that it can run in the target (default) branch context. * Need beta version of plugin to get workflow_run event support. Madrapps/jacoco-report#145 * Download multiple report artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for more event types:
scheduleworkflow_dispatchworkflow_runFor
scheduleandworkflow_dispatch, we don't have the concept of 'changed-files' and so we will only calculate the Overall Project coverage. Also, since there won't be a PR for this, onlycomment-type: summaryis applicable for this.@instrap Maybe we should set
bothas the default value forcomment-type🤔For
workflow_run, if it has a connected PR, we will use that to add a PR Comment with 'changed-files'. If not, we will only do the Overall Project coverage.I will update the README.md during the
v1.7.2release with all this information.Fixes #92
Fixes #34