Split out the PR coverage commenting workflow so that it can run in the target (default) branch context.#3120
Merged
alecgrieser merged 3 commits intoFeb 12, 2025
Conversation
alecgrieser
reviewed
Feb 10, 2025
Comment on lines
+13
to
+14
| github.event.workflow_run.event == 'pull_request' && | ||
| github.event.workflow_run.conclusion == 'success' |
Collaborator
There was a problem hiding this comment.
Did this run in the PRB? Would we expect it to, or is that a sign that something is up?
d4f4067 to
761f225
Compare
alecgrieser
requested changes
Feb 12, 2025
761f225 to
049966c
Compare
alecgrieser
approved these changes
Feb 12, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request tests run in the potentially unsafe context of the base, but can only produce artifacts.
A second workflow is triggered after that and runs in default branch context, so it can be given permission to add a comment to the PR.