PANA-4799: Send text truncation mode#2978
Merged
Merged
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 53d2a45 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2978 +/- ##
===========================================
+ Coverage 70.91% 71.02% +0.11%
===========================================
Files 829 829
Lines 30381 30456 +75
Branches 5184 5201 +17
===========================================
+ Hits 21543 21631 +88
+ Misses 7373 7361 -12
+ Partials 1465 1464 -1
🚀 New features to boost your workflow:
|
ambushwork
previously approved these changes
Nov 13, 2025
0xnm
previously approved these changes
Nov 13, 2025
ambushwork
approved these changes
Nov 17, 2025
0xnm
approved these changes
Nov 20, 2025
| whenever(mockResult.action) doReturn mockAction | ||
| whenever(textLayoutResult.layoutInput) doReturn mockTextLayoutInput | ||
| doAnswer { invocation -> | ||
| @Suppress("UNCHECKED_CAST") |
Member
There was a problem hiding this comment.
very nit: to avoid this Suppress, you can use invocation.getArgument<MutableList<TextLayoutResult>(0) API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The wireframe schema has been updated to allow sending text truncation mode. Possible modes are:
headmiddletailclipThis pr:
• Updates the session replay schema
• Captures and sends truncation mode for native
• Captures and sends truncation mode for compose
• Fixes a small issue with the sample application where it wasn't respecting system windows bounds
Depends on DataDog/rum-events-format#318
Related to DataDog/dd-sdk-ios#2550
Motivation
• Align with iOS on sending text truncation
• More accurate presentation of text when it overflows the bounds of the container.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)