Skip to content

PANA-4768: Capture text truncation mode in Session Replay#2550

Merged
gonzalezreal merged 5 commits into
developfrom
gonzalezreal/PANA-4768/text-truncation-mode
Nov 13, 2025
Merged

PANA-4768: Capture text truncation mode in Session Replay#2550
gonzalezreal merged 5 commits into
developfrom
gonzalezreal/PANA-4768/text-truncation-mode

Conversation

@gonzalezreal

@gonzalezreal gonzalezreal commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

What and why?

Capture text truncation mode in Session Replay and fix vertical alignment for UILabel and SwiftUI.Text.
Depends on DataDog/rum-events-format#318

How?

  • Regenerate Session Replay models from the updated schema
  • Capture label.lineBreakMode in UILabelRecorder and map it to SRTextStyle.TruncationMode
  • Capture the NSParagraphStyle's lineBreakMode in SwiftUIWireframesBuilder and map it to SRTextStyle.TruncationMode
  • Set vertical alignment to top, instead of the default center.
  • Add test coverage

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines (internal) and run make api-surface)

@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
@gonzalezreal gonzalezreal force-pushed the gonzalezreal/PANA-4768/text-truncation-mode branch from 1d95fb6 to 51e754c Compare October 29, 2025 14:08
@jonathanmos jonathanmos mentioned this pull request Nov 6, 2025
Merged
3 tasks
@gonzalezreal gonzalezreal marked this pull request as ready for review November 13, 2025 08:39
@gonzalezreal gonzalezreal requested review from a team as code owners November 13, 2025 08:39
maciejburda
maciejburda approved these changes Nov 13, 2025
View reviewed changes

@maciejburda maciejburda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - curios is it supported by the player?

@gonzalezreal

gonzalezreal commented Nov 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

LGTM - curios is it supported by the player?

@maciejburda They are working on it. See PANA-4772 (internal link).

@gonzalezreal gonzalezreal merged commit 2dfe2d0 into develop Nov 13, 2025
18 checks passed
@gonzalezreal gonzalezreal deleted the gonzalezreal/PANA-4768/text-truncation-mode branch November 13, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maciejburda maciejburda maciejburda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gonzalezreal @maciejburda