Differential D178782

Bug 1834519 - Don't throw when popovers/dialogs are in requested state. r=emilio
ClosedPublic
Actions

Authored by zsun on May 23 2023, 12:51 PM.

Details

Reviewers

emilio

Commits

rMOZILLACENTRAL39007d3d4f3e: Bug 1834519 - Don't throw when popovers/dialogs are in requested state. r=emilio

Bugzilla Bug ID

1834519

Summary

Update to be in line with spec discussions at
https://github.com/whatwg/html/pull/9142

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 541677
Build 638834: arc lint + arc unit

Event Timeline

zsun created this revision.May 23 2023, 12:51 PM

Herald added a project: secure-revision. · View Herald TranscriptMay 23 2023, 12:51 PM

Harbormaster completed remote builds in B540033: Diff 719941.May 23 2023, 12:51 PM

phab-bot published this revision for review.May 23 2023, 12:52 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

mbrodesser-Igalia added a subscriber: mbrodesser-Igalia.May 23 2023, 1:40 PM

mbrodesser-Igalia added inline comments.

dom/html/nsGenericHTMLElement.cpp
3235 ↗	(On Diff #719941)	@zsun: please be aware of https://phabricator.services.mozilla.com/D177486. If possible, please delay submitting this change until the former is merged.

zsun marked an inline comment as done.May 24 2023, 8:10 AM

zsun added inline comments.

dom/html/nsGenericHTMLElement.cpp
3235 ↗	(On Diff #719941)	Thanks! Will wait.

mbrodesser-Igalia added inline comments.May 24 2023, 8:21 AM

dom/html/nsGenericHTMLElement.cpp
3235 ↗	(On Diff #719941)	Thanks! Will wait. @zsun: FYI, the patch landed.

Let's rebase on top of central? Looks good tho.

This revision now requires changes to proceed.May 24 2023, 9:33 AM

zsun requested review of this revision.May 24 2023, 12:52 PM

zsun updated this revision to Diff 720645.

zsun marked an inline comment as done.

Harbormaster completed remote builds in B540685: Diff 720645.May 24 2023, 12:52 PM

mbrodesser-Igalia removed a subscriber: mbrodesser-Igalia.May 24 2023, 12:56 PM

Thanks!

This revision is now accepted and ready to land.May 24 2023, 1:35 PM

Closed by commit rMOZILLACENTRAL39007d3d4f3e: Bug 1834519 - Don't throw when popovers/dialogs are in requested state. r=emilio (authored by zsun). · Explain WhyMay 25 2023, 8:41 AM

This revision was automatically updated to reflect the committed changes.

zsun added a commit: rMOZILLACENTRAL39007d3d4f3e: Bug 1834519 - Don't throw when popovers/dialogs are in requested state. r=emilio.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

dom/

html/

HTMLDialogElement.cpp

19 lines

96%

testing/

web-platform/

meta/

html/

semantics/

interactive-elements/

the-dialog-element/

dialog-no-throw-requested-state.html.ini

Diff 721217

View Options

dom/html/HTMLDialogElement.cpp