Page MenuHomePhabricator
Differential D177486

Bug 1832033: change `CheckPopoverValidity` to match spec more closely. r=emilio
ClosedPublic
Actions

Authored by mbrodesser-Igalia on May 9 2023, 12:08 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Jun 7, 9:37 AM
Unknown Object (File)
Tue, May 26, 3:44 PM
Unknown Object (File)
Mon, May 25, 6:22 PM
Unknown Object (File)
May 8 2026, 9:25 PM
Unknown Object (File)
Apr 26 2026, 3:29 AM
Unknown Object (File)
Apr 25 2026, 9:36 AM
Unknown Object (File)
Apr 25 2026, 5:44 AM
Unknown Object (File)
Apr 25 2026, 2:28 AM
View All 21 Files
Subscribers
None

Details

Reviewers
emilio
Commits
rMOZILLACENTRAL38cfebe42935: Bug 1832033: change `CheckPopoverValidity` to match spec more closely. r=emilio
Bugzilla Bug ID
1832033

Diff Detail

Event Timeline

mbrodesser-Igalia created this revision.May 9 2023, 12:08 PM
Herald added a project: secure-revision. · View Herald TranscriptMay 9 2023, 12:08 PM
Harbormaster completed remote builds in B534806: Diff 713749.May 9 2023, 12:08 PM
phab-bot published this revision for review.May 9 2023, 12:10 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
mbrodesser-Igalia planned changes to this revision.May 9 2023, 12:25 PM

Just a few hours a spec-change was pushed: https://github.com/whatwg/html/commit/ba956cb1fe2f44171f8401a284e83fc7e0043647. Will incorporate it here.

mbrodesser-Igalia planned changes to this revision.May 9 2023, 1:11 PM
mbrodesser-Igalia updated this revision to Diff 713808.
mbrodesser-Igalia retitled this revision from Bug 1832033: change `CheckPopoverValidity` to match spec more closely. r=emilio to WIP: Bug 1832033: change `CheckPopoverValidity` to match spec more closely. r=emilio.
Harbormaster completed remote builds in B534861: Diff 713808.May 9 2023, 1:11 PM
mbrodesser-Igalia added a comment.May 9 2023, 1:13 PM

Will update the corresponding WPT expectations once the updated tests (https://github.com/web-platform-tests/wpt/pull/39781/commits/6403f546bd460256e8a8bf270f633c0799babe53#) are merged.

mbrodesser-Igalia requested review of this revision.May 22 2023, 12:45 PM
mbrodesser-Igalia updated this revision to Diff 719399.
mbrodesser-Igalia retitled this revision from WIP: Bug 1832033: change `CheckPopoverValidity` to match spec more closely. r=emilio to Bug 1832033: change `CheckPopoverValidity` to match spec more closely. r=emilio.
Harbormaster completed remote builds in B539658: Diff 719399.May 22 2023, 12:45 PM
mbrodesser-Igalia updated this revision to Diff 719446.May 22 2023, 1:59 PM
Harbormaster completed remote builds in B539709: Diff 719446.May 22 2023, 1:59 PM
mbrodesser-Igalia mentioned this in D177377: Bug 1831097: declare `HTMLElement`'s `togglePopover` argument `force` `optional`. r=emilio.May 23 2023, 9:04 AM
emilio accepted this revision.May 23 2023, 9:50 AM
emilio added a project: testing-approved.
This revision is now accepted and ready to land.May 23 2023, 9:50 AM
mbrodesser-Igalia mentioned this in D178782: Bug 1834519 - Don't throw when popovers/dialogs are in requested state. r=emilio.May 23 2023, 1:40 PM
mbrodesser-Igalia added a child revision: D177377: Bug 1831097: declare `HTMLElement`'s `togglePopover` argument `force` `optional`. r=emilio.May 23 2023, 1:43 PM
mbrodesser-Igalia updated this revision to Diff 720015.May 23 2023, 2:24 PM
Harbormaster completed remote builds in B540081: Diff 720015.May 23 2023, 2:24 PM
Closed by commit rMOZILLACENTRAL38cfebe42935: Bug 1832033: change `CheckPopoverValidity` to match spec more closely. r=emilio (authored by Mirko Brodesser <mbrodesser@igalia.com>). · Explain WhyMay 23 2023, 2:48 PM
This revision was automatically updated to reflect the committed changes.
mbrodesser-Igalia added a commit: rMOZILLACENTRAL38cfebe42935: Bug 1832033: change `CheckPopoverValidity` to match spec more closely. r=emilio.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
dom/
html/
19 lines97%
Loading...
testing/
web-platform/
meta/
html/
semantics/
popovers/
9 lines--
--
2 lines--

Diff 720111

View Options

dom/html/nsGenericHTMLElement.cpp

Loading...
View Options

testing/web-platform/meta/html/semantics/popovers/popover-attribute-basic.html.ini

Loading...
View Options

testing/web-platform/meta/html/semantics/popovers/popover-move-documents.html.ini

Loading...
View Options

testing/web-platform/meta/html/semantics/popovers/popover-stacking-context.html.ini

Loading...
Privacy · Cookies · Legal