Vitalii Elenhaupt comments

Results 68 comments of


                                            Vitalii Elenhaupt

Please make AASM compatible with JSON::Serializable

Hey, this is a nice idea. It happens because there is no way to convert a proc to json and back. Thanks for the investigation, I will take a look...

[FEATURE] Skip gm altogether if there are no faces deteced

Hey @afoeder. Thanks for the interest. Could you please explain why would you like to do this? Yes, it can be done, however will lead to a slight refactoring since...

[FEATURE] Skip gm altogether if there are no faces deteced

Ok, this makes sense. Will rework this once i have some time

If no JSON API payload was found should render JSON API compliant error

@beauby any suggestion on how to add a `status` and `links` to the error response? ```ruby if event.save render jsonapi: event, status: :created else render jsonapi_errors: event.errors, status: :unprocessable_entity end...

Generates docs automatically

Will take a look what i can do :)

Generates docs automatically

@j8r thanks. You were right regarding `GITHUB_TOKEN`. I didn't want to share it, sorry. Good to know about GitHub Action.

Crystal callback

Currently it is possible to do the following: ```crystal stack = Lua::Stack.new proc = ->(state : LibLua::State) { puts LibLua.tonumberx(state, 1, nil) return 0 } # push crystal proc onto...

Crystal callback

@zatherz sorry, I don't have so much time for this now. Will try to work on it during coming weeks. If you are able to prepare PR I would love...

Crystal callback

Well, the example above is low level. For convenience `lua.cr` is designed to be more high level. The API I am thinking about is the following: ```crystal lua = Lua.load...

Crystal callback

You can try to start and create PR on early stage, so we can discuss it if needed. PS: I was highly inspired by ruby's version of this: [rufus-lua](https://github.com/jmettraux/rufus-lua). That...