Sam

Results 4 issues of Sam

I get an exception in my core buffer when someone sends unicode characters to a channel, like below. I'm on Python 3.6.3. https://puu.sh/yntz6/1e4f54f40d.png

bug
upstream

If you feed the `ban()` method a full mask, like `*!*@host`, it tries to ban `*!*@*!*@host` - basically if it's not a known user on the channel, it prepends `*!*@`...

https://github.com/Throne3d/node-irc/blob/2a5f46d4c1cd7fd7a9929a24bcb9879585b5cd5a/lib/irc.js#L756-L762 In some cases, it's useful to connect with a server password and a SASL password, so it might be useful to have a separate config option for SASL password...

https://github.com/pyskell/LicenseServer/blob/9beb984c92f8c37a591c1c26a715eabff0a57374/auth.py#L48 I would not trust the randomness of this function. You should use this module instead: https://docs.python.org/3/library/secrets.html#module-secrets. https://github.com/pyskell/LicenseServer/blob/9beb984c92f8c37a591c1c26a715eabff0a57374/auth.py#L35 This is vulnerable to a timing attack, Use a constant time comparison...

bug