Rui Marinho
Rui Marinho
We will soon merge https://github.com/ruimarinho/bitcoin-core/pull/106 so maybe we can release this as patch and land a new options method in the upcoming major release.
@justinmeiners pull requests are open so you contribute to the security of this module by submitting patches - I'd appreciate that. Are you able to demonstrate an attack based on...
Happy to change this behaviour if there are better ways of achieving the same result while adding more flexibility. @rom-burner @LordShadowen do you plan on submitting a PR? Why wouldn't...
Can you give https://github.com/ruimarinho/docker-bitcoin-core/pull/120 a try?
I should be able to merge this EOD today. Sorry for the delay on this one.
That would be great, @m0rtalis!
Hey @nickphbrown. Doesn't https://github.com/ruimarinho/gsts/blob/bde055fa130ca0e99097c8e0aee0b3c05325920e/credentials-manager.js#L203-L222 serve that purpose already?
@spasam I like the idea but I would prefer if this was done under `credentials-manager.js` to make it testable (https://github.com/ruimarinho/gsts/blob/master/credentials-manager.js#L89). Can you make that change please?
Thank you! Could you please add a test to ensure the feature remains covered? Appreciated!
That looks good! Are you able to post the output of gsts in verbose mode so I can see its structure when aliases are included (redacting any sensitive information)?