Piotr Witek

Results 171 comments of Piotr Witek

I'm proposing this updated version instead, which adds usage example and has a more dev friendly displayName in the DevTools: ```ts export interface FancyButtonProps { className?: string; children?: React.ReactNode; }...

That's an interesting suggestion, unfortunately I'm not using recompose on daily basis but this is something I was interested in learning at some point. btw. contributions are welcomed :)

Planned work: - add a new recompose section with setup instructions - add usage code examples of the most common recompose API in the playground project - add autogeneration of...

Hey, 1) ```ts type Props = { courses: CourseModel[]; onFetchCourseRequest: () => void // or typeof courseActions.fetchCoursesRequest }; ``` 2) I dunno who told to use the below line but...

Thanks for the feedback, I'll think about some ways to improve the guide in the mentioned areas. Error handling all depends where and how you want to display errors in...

@dcs3spp here is an example implementation from my WIP side-project about global error handling: https://github.com/piotrwitek/react-redux-typescript-realworld-app/blob/master/src/features/articles/epics.ts#L46 Unfortunately, I don't have much time to work on each of my side-projects full time...

It seems you can have a problem of not unmounting the component when an error occurs, that's why it doesn't run request to fetch the data and clear error on...

Hey @parkerault Thanks for sharing your ideas. It makes sense, I'll have to think about how to break it down and take out redux-observables from a core to make it...

Sounds good, could be added as an alternative approach to the guide in the Class components section.

@shaun-sweet sure go for it. Please try to keep as much consistency as possible in terms of guide structure and naming/casing conventions across the examples.