Bin Liu

Results 58 issues of Bin Liu

If a PR only has docs/ content changed, then skip other CI checks. Fixes: #4835 Signed-off-by: Bin Liu

do-not-merge
size/small

`route` is not needed https://github.com/kata-containers/kata-containers/blob/runtime-rs/src/runtime-rs/crates/resource/src/network/network_model/route_model.rs /cc @lifupan @quanweiZhou

enhancement
needs-review
runtime-rs

If the API server is not ready, the mount call will fail, so before mounting share fs, we should wait the nydusd is started and the API server is ready....

size/medium

@ManaSugi has created `runk` as a container runtime, it works only with some sub-commands that are not unimplemented. This issue is used to track these unimplemented sub-commands. ## basic features...

enhancement
needs-review
soc

Sometimes static check complains this error(Full link: https://github.com/kata-containers/kata-containers/runs/6014924735?check_suite_focus=true): It's not a 100% reproducible issue. ``` test rpc::tests::test_append_guest_hooks ... ok test rpc::tests::test_add_arp_neighbors ... ok test rpc::tests::test_get_memory_info ... ok test rpc::tests::test_load_kernel_module ......

bug
needs-help
needs-review

Test fails on Ubuntu 22.04 because `status::get_all_pid` only works on cgroup v1 now. Temporarily skip tests on cgroup v2 environment. Please run test again. @ManaSugi @liubin _Originally posted by @cyyzero...

`kata-runtime check` run checks for KVM/Kernel modules. Add check of CRI(CRI-O containerd)'s version checks sometimes may be helpful to troubleshooting.

enhancement
good-first-issue
area/runtime

In agent there are many `Error`s returned by: ```rust return Err(anyhow!(nix::Error::from_errno(Errno::EINVAL))); ``` With this we might only get an error message of "Invalid argument". These errors are lack of detail...

enhancement
area/agent

Our CI (static check) has two unit test jobs, one is running as normal, and the other one will run tests as root user. https://github.com/kata-containers/kata-containers/blob/ac91fb7a126238b595afa59c17fbb82a12c4f5ad/.github/workflows/static-checks.yaml#L89-L96 But `make test` under `src/runtime`...

enhancement
needs-review

In some cases do_create_container may return an error, mostly due to `container.start(process)` call. This commit will do some rollback works if this function failed. Fixes: #4749 Signed-off-by: Bin Liu

wip
needs-backport
size/medium