Etienne Lawlor comments

Results 36 comments of


                                            Etienne Lawlor

Edge case issue on shared element transition return

I did not fix this @gaoneng102 , I am hoping that @alexjlockwood can provide some insight.

Edge case issue on shared element transition return

@gaoneng102 which answer is it in that stack overflow post : (http://stackoverflow.com/questions/8785221/retrieve-a-fragment-from-a-viewpager) ?

Edge case issue on shared element transition return

@gaoneng102 can you explain how this fixes the shared element return transition?

Edge case issue on shared element transition return

I just tried this ``` java @Override public void setPrimaryItem(ViewGroup container, int position, Object object) { // super.setPrimaryItem(container, position, object); // currentDetailsFragment = (GalleryDetailsFragment) object; currentDetailsFragment = (GalleryDetailsFragment) getRegisteredFragment(position); super.setPrimaryItem(container,...

Edge case issue on shared element transition return

Thanks. This seems to work a little bit better. But if I stress test it, it ends up doing a massive garbage collection. So I don't know what is leaking...

Issue regarding Shared Element Transition

You need to set the currentItem of the ViewPager to the appropriate int. You also need to postponeentertransition until the image in fragment B has finished loading.

Presenter.detachView() is never called

Yep I don't see this called anywhere.

animated setPosition

Can you give me some context of what you are trying to do? are you clicking a button that then calls setPosition() in the DiscreteSlider?

animated setPosition

Do you mind sharing a screenshot?

animated setPosition

can I close this issue?