Luca Guidi

Results 84 comments of Luca Guidi

`hanami-view` rendering scope (`Hanami::View::Rendering::LayoutScope`) inherits from `BasicObject`. By temporary removing this inheritance the broken tests passes again: ```diff diff --git a/lib/hanami/view/rendering/layout_scope.rb b/lib/hanami/view/rendering/layout_scope.rb index 5c5fca3..a6ee651 100644 --- a/lib/hanami/view/rendering/layout_scope.rb +++ b/lib/hanami/view/rendering/layout_scope.rb @@...

By debugging https://github.com/rtomayko/tilt/commit/be625c89a9e3717fe23f90f9ded0c8a503b66a7d#diff-4757dfc1f8a5b4b4ab833adbe73c5785R169 I found an interesting, but confusing detail: When `Hanami::View::Rendering::LayoutScope` inherits from `BasicObject`, `scope.is_a?(Module)` returns `true`: ```ruby (byebug) scope #">, @rendered="">" @scope="#"> (byebug) scope.is_a?(Module) true ``` When it...

@jeremyevans thanks for the quick patch on `erubi`. However, the problem isn't just for `::String`. For instance, while running `hanami-view` specs with `tilt` `2.0.10`, I get a similar error but...

@jeremyevans You hit the point: > NoMethodError (unless you are also defining an is_a? method on the class.) `Hanami::View::Rendering::LayoutScope` defines `#method_missing` to forward message passing to the scope that it...

@shekhargulati Is it fine with you if I adapt that Getting Started guide for the purpose?

@craigfrancis Thanks for your proposal, this is brilliant. I **really** hope that vendors will eventually implement this.

@rngtng The project where I'm using this feature is low priority. I want this feature to be driven by real world needs, that's why this PR is not finished yet.

@IvanShamatov This is useful, indeed. What I suggest if it's possible to use message passing, instead of system calls to execute other commands it would be preferrable. But if that...

@deepj Please remember that when testing against `apps/*-1.ru` you should do `GET /`, instead of `GET /j/j/j/j`. 🙂

There is something that doesn't look good. The spec doesn't pass locally, but it does over CI. My intent was to reproduce the bug only, so the build supposed to...