Chris Stockton

Results 52 comments of Chris Stockton

There are many options besides committing a breaking change and causing months of collateral damage. If you want a good example of what happens when a project has a breaking...

@jeffallen When backwards compatibility is broken for thousands of projects people have every right to voice their concern. There is a reason Go has the backwards compatibility guarantee, it was...

I believe this should be reverted as soon as possible, to do that we should probably only rollback the prior commits to remove any points of contention around the API....

Looks like this issue is a bit old, but it took me a few minutes of digging to figure out how to do this properly so figured I would share:...

@yspanchal You would want to wrap the [grpc.StreamServerInterceptor](https://godoc.org/google.golang.org/grpc#StreamServerInterceptor) - it's just an ordinary function so you can wrap the call to the sbprom interceptors. ```Go func certainConditionWrapper( maybe grpc.StreamServerInterceptor, )...

Would you accept a bytes.Buffer pull request that did the same thing? Would just allocate a backing ahead of time similar to string builder and string() the byte slice.

Was this rejected for some reason or should I update it?

So the original change in #150 was much more impactful, at 90-97% memory & 50% CPU reductions. It was merged by hand which missed some changes as well as causing...

Could this use a technique similar to causer.Cause with assertion for stackTracer? i.e.: ```Go func isStackTracer(err error) (ok bool) { if err == nil { return } if _, ok...

@yurishkuro I don't think the function in #152 should be implemented, the behavior should be the default here. If a span is derived from a parent span, it should use...