Cristina Mantilla Suarez

Results 9 comments of Cristina Mantilla Suarez

It shouldn't be, but is possible that the TOA correction is actually causing this? Can you check if it is positive before this line? https://github.com/LDMX-Software/Hcal/blob/trunk/src/Hcal/HcalRecProducer.cxx#L103

hi @EinarElen, looking at this on more detail, we made this change of a factor of 2 because of issue [16](https://github.com/LDMX-Software/Hcal/issues/16). I think the `num_mips_equivalent` should stay as is since...

hi @EinarElen, thinking about using this for clustering plots in the DR and I want to make sure that the position reconstruction is understood. Could you provide from your file...

Ok will do: - Expand HcalDigiPipeline test to include multiple sim-hit reconstruction (handle hits separated by space or time, or both)

Was able to reproduce this issue. It is a bug on the HcalRecProducer, fixed with [this commit](https://github.com/LDMX-Software/Hcal/commit/5c33cfaab9c26913ef48b9ec06f5c0fe6dcd3ab9). Should be integrated when issue 40 is fully tested.

It looks like this branch was never integrated. But the reconstruction got split into two different files: https://github.com/LDMX-Software/ldmx-sw/blob/trunk/Hcal/src/Hcal/HcalDoubleEndRecProducer.cxx https://github.com/LDMX-Software/ldmx-sw/blob/trunk/Hcal/src/Hcal/HcalSingleEndRecProducer.cxx and the first file contains this fix. I am not sure...

What kind of test is running that gives: "Evaluator : unknown variable"?

So you are OK with not having SPs for now?

I think that most the work to use TOT in the reconstruction was done in the changes to the hcal reco conditions in this PR. So we can close this...