Ben Torvaney

Results 40 comments of Ben Torvaney

I think I am seeing a similar issue: ```python import dataclasses import datetime import typing import dataclasses_json import marshmallow @dataclasses_json.dataclass_json @dataclasses.dataclass(frozen=True) class Example: some_datetime_field: typing.Optional[datetime.datetime] = dataclasses.field( default=None, metadata=dataclasses_json.config( encoder=datetime.datetime.isoformat,...

Alternatively, since the `td_format` in each of these cases is going to be pretty lightweight, allowing a formatting function to be passed as an argument to `Col` would be pretty...

Hey! This is a good suggestion; thanks for opening it. Adding model evaluation metrics generally seems like a really good idea. RPS is, as you point out, particularly nice for...

These can be adapted from the statsandsnakeoil.com blog posts as well

Split out extensive `dixoncoles` examples from README into vignettes

Maybe explore using ggforce, too

Some ideas: 1. Enable negative pitch widths in pitch spec 2. Add an additional parameter to pitch spec, on whether the origin is on the left or right of the...

Equally - how big an issue is this, since `scale_y_reverse` exists? Seems like the best option might be add an optional param to the pitch dimensions that tells `annotate_pitch` whether...

> When you use half size to plot shots , it should be required an scale y reverse Ah yes, this is correct. I will update the README to reflect...

I've submitted an issue to ggplot2 [here](https://github.com/tidyverse/ggplot2/issues/3120). The workaround for `geom_rect` -> `annotate(geom = "rect", ...)` works fine, but getting the pitch circles to behave is a bit tricker. I...