Miki Watanabe
Miki Watanabe
Hi there, I'm interested in working on this issue(this will be my first contribution). I'm guessing I'm supposed to write some unit tests related to this bug?
Hi there, Can I work on this?
@jklymak my PR is pretty much good to go(passed all checks), so would love to have a review. Thank you in advance!
Is there anything I can/should do to fix the test failures from CI?
Finally passed all checks! I was wondering if I should keep using the original methods(safe_first_element()) or the _safe_non_none() for all tests that uses safe_first_element. I am pretty sure that I...
> @MikiPWata Do you feel comfortable squashing this to one commit? yes! I will squash them into 1 commit
not sure why many pytests are failing....
> And with the suggested changes we need to find all our usage of `safe_first_element` and replace with `_safe_first_non_none`. > > This way we (internally) always use the new behavior,...
working on this
working on `Object Restore initiated`