fix(modernx): avoid nil error when generating comment filename#68
Merged
zydezu merged 1 commit intozydezu:mainfrom Jun 23, 2025
Merged
fix(modernx): avoid nil error when generating comment filename#68zydezu merged 1 commit intozydezu:mainfrom
zydezu merged 1 commit intozydezu:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When playing videos from URLs such as Bilibili, the script
modernx.luaattempts to construct a.info.jsonpath using the video filename. However, ifmp.get_property("filename")returnsnil, or if the result of:match(...)returnsnil, the script crashes with the following error:This happens at line 1751 and interrupts the playback experience, especially when comments are enabled.