Improve ZydisRegisterGetLargestEnclosing#456
Merged
Conversation
athre0z
approved these changes
Oct 1, 2023
Member
athre0z
left a comment
There was a problem hiding this comment.
Thanks -- looks good to me! :)
flobernd
commented
Oct 1, 2023
Contributor
|
Also good opportunity to add tests for this maybe? |
athre0z
approved these changes
Oct 9, 2023
athre0z
added a commit
that referenced
this pull request
Feb 4, 2024
This reverts the interface-breaking portion of 6ab4463.
athre0z
pushed a commit
that referenced
this pull request
Feb 4, 2024
athre0z
added a commit
that referenced
this pull request
Feb 4, 2024
This reverts the interface-breaking portion of 6ab4463.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #443