Use absolute URL for logo & make logo link to website#405
Merged
athre0z merged 2 commits intozyantific:masterfrom Nov 27, 2022
rich-ayr:patch-1
Merged
Use absolute URL for logo & make logo link to website#405athre0z merged 2 commits intozyantific:masterfrom rich-ayr:patch-1
athre0z merged 2 commits intozyantific:masterfrom
rich-ayr:patch-1
Conversation
Fixes logo on mobile app (see #404 (comment))
athre0z
approved these changes
Nov 27, 2022
Member
athre0z
left a comment
There was a problem hiding this comment.
Using this internal GitHub URL directly seems like something that has a pretty decent chance of randomly breaking at some point in the future. But honestly I don't really care: we can just revert to relative paths when it does. Personally I would also not have cared about breaking the iOS app since that is clearly a bug in the app.
Member
|
Thinking the same here. That's why I did not merge right away. Should be reported as a bug for the iOS app. |
athre0z
pushed a commit
that referenced
this pull request
Feb 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes logo on mobile app (see #404 (comment))