build(cmake): export and install zyan_* functions#33
build(cmake): export and install zyan_* functions#33athre0z merged 1 commit intozyantific:masterfrom
Conversation
This requires a Zycore version with zyantific/zycore-c#33 applied
This requires a Zycore version with zyantific/zycore-c#33 applied
You can remove the DESTINATION but you need to keep the ARCHIVE keyword, like this: |
I'm not sure about that. From the docs: For each of these arguments given, the arguments following them only apply to the target or file type specified in the argument. If none is given, the installation properties apply to all target types. If only one is given then only targets of that type will be installed If I understand this correctly, they are only used to define properties of specific types of targets and limit the types that can be installed. Since here we don't have to define type-specific properties, specifying Also, |
|
Oops, I thought the keyword allowed you to choose which files to install. |
athre0z
left a comment
There was a problem hiding this comment.
Thanks, looks good in general! Left one minor comment to discuss.
Now when calling find_package(Zycore) users will be able to use the zyan functions. This would make it possible to use find_package(Zycore) to find and use the system Zycore library in Zydis. Before this change, if instead of compiling Zycore with add_subdirectory() you used find_package(Zycore), the build failed, because functions like zyan_set_common_flags() were not imported.
ec92dfd to
464f804
Compare
This requires a Zycore version with zyantific/zycore-c#33 applied
This requires a Zycore version with zyantific/zycore-c#33 applied
Now when calling
find_package(Zycore)users will be able to use thezyanfunctions.This would make it possible to use
find_package(Zycore)to find and use the system Zycore library in Zydis. Before this change, if instead of compiling Zycore withadd_subdirectory()you usedfind_package(Zycore), the build failed, because functions likezyan_set_common_flags()were not imported.I also removed
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}etc frominstall(TARGETS ...)because they are already set by default