Remove feature "randomized capitalization"#207
Merged
marc-vanderwal merged 4 commits intoMay 20, 2025
Conversation
Contributor
|
@marc-vanderwal This draft PR can now proceed (rebased on latest develop), as v2024.2 has been released. |
Contributor
Author
I agree: all preconditions are met, so let’s proceed with the change. |
No longer document the --randomize command-line argument to Makefile.PL, which is about to be removed.
Remove the possibility to define RANDOMIZE in CFLAGS by removing --randomize as a valid CLI argument.
Remove the deprecated feature entirely.
Remove a case-insensitive comparison that was done in t/rr.t in order to make unit tests pass on installations where the now removed case randomization feature was enabled. Previously, this equality comparison was done case-sensitively, which only worked when this feature was disabled. With this change, we can now be almost certain that we don’t do any case alterations anymore.
f274b99 to
69054fb
Compare
Contributor
Author
|
I’ve just rebased on latest |
matsduf
approved these changes
May 7, 2025
tgreenx
approved these changes
May 13, 2025
|
Looks fine in Ubuntu 22.04 |
Contributor
|
Degrade from "V-Minor" to "V-Patch" since the feature is unused by Zonemaster and this component is for Zonemaster only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR removes an experimental and previously deprecated “randomized capitalization” feature from Zonemaster-LDNS.
Context
See #160 for the issue and discussion, and #206 for the initial deprecation warnings.
Changes
Remove the “randomized capitalization” feature from Zonemaster-LDNS. Update the documentation accordingly.
How to test this PR
In the root of the source tree of Zonemaster::LDNS, run cpanm -v --configure-args="--random" .
Among the roughly 30 first lines of output, expect this output (the version number of
Zonemaster-LDNSmay vary):Also, expect unit tests (which have been updated) to pass.