Rerender tests correctly#523
Merged
matsduf merged 2 commits intoDec 15, 2025
Merged
Conversation
matsduf
approved these changes
Dec 12, 2025
matsduf
left a comment
Contributor
There was a problem hiding this comment.
I see no issues, and when testing the history functions as it should.
MichaelTimbert
approved these changes
Dec 15, 2025
MichaelTimbert
left a comment
There was a problem hiding this comment.
Bug is fixed. But beware there is some issues when merging with #520 .
Contributor
|
@tbleckert thanks for the fix. could you fix the conflicts by rebasing this PR? |
marc-vanderwal
approved these changes
Dec 15, 2025
|
I tested this #523 rebased on #511 (after #520 rebase). I encountered a conflict, but everything works correctly after fixing it. To resolve the conflict I only remove one |
6d3eedc to
311e1d9
Compare
Merged
Contributor
|
@marc-vanderwal, @tgreenx and @MichaelTimbert, I will merge this PR. |
f3dbf6d
into
zonemaster:releases/ssg-standalone-components
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #522
Context
When navigating between test results, for example via the History dialog, the view didn’t update with the correct data. The issue was caused by a Svelte component relying on local state, which prevented it from reacting when the incoming data object changed.
Changes
ResultInfo now uses a derived rune instead of local state, which ensures it updates whenever the passed data changes. The history navigation has also been updated to include the language prefix.
How to test this PR
Run a test, then switch to an older one via the History dialog. The displayed data should update immediately and correctly. Also verify that reloading the page shows the same data.