Skip to content

Update implementation of Nameserver15#1306

Merged
tgreenx merged 2 commits into
zonemaster:developfrom
tgreenx:update-nameserver15
Nov 20, 2023
Merged

Update implementation of Nameserver15#1306
tgreenx merged 2 commits into
zonemaster:developfrom
tgreenx:update-nameserver15

Conversation

@tgreenx

@tgreenx tgreenx commented Nov 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Purpose

This PR proposes an update to the implementation of Nameserver15 following an update to the specification (zonemaster/zonemaster#1199).

Unit tests and data are also updated, based on zonemaster/zonemaster#1217.

Context

Test Case specification: zonemaster/zonemaster#1199
Test Zones specification: zonemaster/zonemaster#1217

Changes

lib/Zonemaster/Engine/Test/Nameserver.pm

  • Update implementation
  • Update message tags and message ids

share/profile.json and share/profile.yaml

  • Update message tags

t/Test-nameserver15.t and t/Test-nameserver15.data

  • Update unit tests implementation
  • Update unit tests data

How to test this PR

Unit tests should pass.

Manual testing:

$ git log -1 --oneline
f4af7a28 (HEAD -> update-nameserver15, origin/update-nameserver15) Update implementation of Nameserver15

$ zonemaster-cli --test=nameserver/nameserver15 --show-testcase --level=INFO --no-ipv6 zonemaster.net
Seconds Level    Testcase       Message
======= ======== ============== =======
   0.00 INFO     UNSPECIFIED    Using version v4.7.3 of the Zonemaster engine.
   1.65 NOTICE   NAMESERVER15   The following name server(s) respond to software version query "version.bind" with string "9.18.19". Returned from name servers: "ns2.nic.fr/192.93.0.4"
   1.65 INFO     NAMESERVER15   The following name server(s) do not reveal the software version. Returned from name servers: "nsa.dnsnode.net/194.58.192.46;nsp.dnsnode.net/194.58.198.32;nsu.dnsnode.net/185.42.137.98"

$ zonemaster-cli --test=nameserver/nameserver15 --show-testcase --level=INFO --no-ipv6 afnic.fr
Seconds Level    Testcase       Message
======= ======== ============== =======
   0.00 INFO     UNSPECIFIED    Using version v4.7.3 of the Zonemaster engine.
   0.58 NOTICE   NAMESERVER15   The following name server(s) respond to software version query "version.bind" with string "9.18.19". Returned from name servers: "ns1.nic.fr/192.134.4.1;ns2.nic.fr/192.93.0.4;ns3.nic.fr/192.134.0.49"
   0.58 NOTICE   NAMESERVER15   The following name server(s) respond to software version query "version.bind" with string "host-02". Returned from name servers: "g.ext.nic.fr/194.0.36.1"

@tgreenx
Update implementation of Nameserver15
f4af7a2 
Follows test specification update (zonemaster/zonemaster#1199).

Unit tests and data are also updated, based on zonemaster/zonemaster#1217.
@tgreenx tgreenx added A-TestCase Area: Test case specification or implementation of test case V-Minor Versioning: The change gives an update of minor in version. labels Nov 16, 2023
@tgreenx tgreenx added this to the v2023.2 milestone Nov 16, 2023
matsduf
matsduf previously approved these changes Nov 19, 2023
View reviewed changes

@matsduf matsduf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. The t file needs update to match the updated scenarios in zonemaster/zonemaster#1217

@tgreenx

tgreenx commented Nov 20, 2023

Copy link
Copy Markdown
Contributor Author

This is fine. The t file needs update to match the updated scenarios in zonemaster/zonemaster#1217

Unit test is fixed. Please re-review.

@tgreenx tgreenx requested a review from matsduf November 20, 2023 11:40
@tgreenx tgreenx merged commit 44c81e6 into zonemaster:develop Nov 20, 2023
@tgreenx tgreenx deleted the update-nameserver15 branch November 20, 2023 12:20
@tgreenx tgreenx mentioned this pull request Dec 5, 2023
Closed
@tgreenx tgreenx linked an issue Dec 5, 2023 that may be closed by this pull request
Nameserver15 may use TXT records of wrong class when processing response to CH TXT queries zonemaster/zonemaster#1208
Closed
@matsduf matsduf mentioned this pull request Dec 11, 2023
Closed
@hannaeko hannaeko self-assigned this Jan 10, 2024
@hannaeko hannaeko added the S-ReleaseTested Status: The PR has been successfully tested in release testing label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matsduf matsduf matsduf approved these changes
@mattias-p mattias-p Awaiting requested review from mattias-p
@hannaeko hannaeko Awaiting requested review from hannaeko
@marc-vanderwal marc-vanderwal Awaiting requested review from marc-vanderwal

Assignees

@hannaeko hannaeko

Labels

A-TestCase Area: Test case specification or implementation of test case S-ReleaseTested Status: The PR has been successfully tested in release testing V-Minor Versioning: The change gives an update of minor in version.

Projects

None yet

Milestone

v2023.2

Development

Successfully merging this pull request may close these issues.

Nameserver15 may use TXT records of wrong class when processing response to CH TXT queries

3 participants

@tgreenx @matsduf @hannaeko