Updates NAMESERVER15 by matsduf · Pull Request #1199 · zonemaster/zonemaster

matsduf · 2023-08-25T18:28:03Z

Purpose

The objective of the test case states about name servers that "it may sometimes be desirable not to reveal that information" but then if it does, this test case only sends an INFO message. An INFO message does not signal that there is any reason to look at it. This PR raises the level to NOTICE.

$ zonemaster-cli --test nameserver/nameserver15 telia.com --raw
   0.00 INFO     UNSPECIFIED    GLOBAL_VERSION   version=v4.7.2
   1.57 INFO     NAMESERVER15   N15_SOFTWARE_VERSION   ns_ip_list=dns358.fi.telia.net/88.194.40.67;dns49.de.telia.net/2001:2030:c000:5::4;dns49.de.telia.net/213.248.77.82; query_name=version.bind; string=9.18.9
   1.58 INFO     NAMESERVER15   N15_SOFTWARE_VERSION   ns_ip_list=dns1.telia.com/2001:2040:c001:101::5;dns1.telia.com/81.228.11.67;dns2.telia.com/2001:2040:c001:401::6;dns2.telia.com/81.228.10.67; query_name=version.bind; string=9.18.11

The specification does not distinguish between a server that does not respond at all on a "version query" and a server that responds, but with no version information. In the following example some of the servers do not respond at all and some of them responds with no information. This PR splits the message and make the test case make a distinction.

$ zonemaster-cli --test nameserver/nameserver15 festo.press --raw
   0.00 INFO     UNSPECIFIED    GLOBAL_VERSION   version=v4.7.2
  41.67 INFO     NAMESERVER15   N15_NO_VERSION   ns_ip_list=ns2.atvirtual.com/185.136.96.210;ns2.atvirtual.com/2a06:fb00:1::1:210;ns6.atvirtual.com/185.136.97.210;ns6.atvirtual.com/2a06:fb00:1::2:210;ns7.atvirtual.com/185.136.98.210;ns7.atvirtual.com/2a06:fb00:1::3:210;ns8.atvirtual.com/185.136.99.210;ns8.atvirtual.com/2a06:fb00:1::4:210

This PR also make the test case skip servers that do not even answer SOA queries to make it lift up any servers that do not answer because it is a "version query".

This PR also changes the argument from ns_ip_list to ns_list to give more information. It uses the same technique introduced by #1179.

This PR also updates the test case to check the class in the response.

Context

Also see zonemaster/zonemaster-engine#1281

Also see #1208

Also see test zones that match this update in #1217.

Changes

The specification of NAMESERVER15.

How to test this PR

Review the proposed changes.

matsduf · 2023-08-25T18:29:40Z

@tgreenx, you wrote the specification. Please review this proposal of updates.

…en outputted

…name

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

* Adds test for class on the TXT records * Remove check of owner name of TXT records * Editorial update

matsduf · 2023-09-15T10:37:12Z

@tgreenx and @marc-vanderwal, please re-review.

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

matsduf · 2023-10-18T19:02:40Z

@marc-vanderwal, are you also fine with this?

marc-vanderwal

Yes, that looks good to me!

matsduf · 2023-10-19T15:42:13Z

Test zone specification for this test case in #1217

…from version string

matsduf · 2023-10-27T13:18:34Z

@tgreenx and @marc-vanderwal, I made a version string just consisting of space to be equal to empty version string.

matsduf · 2023-10-27T21:17:58Z

Test zone specification for this test case in #1217

Now the test zones have been implemented.

matsduf · 2023-10-30T15:09:07Z

@tgreenx, you did the current implementation of Nameserver15. Could you do the update?

tgreenx · 2023-10-30T15:31:30Z

@tgreenx, you did the current implementation of Nameserver15. Could you do the update?

Yes

Follows test specification update (zonemaster/zonemaster#1199). Unit tests and data are also updated, based on zonemaster/zonemaster#1217.

matsduf · 2023-11-19T22:45:42Z

A trivial merge conflict was resolved after two approvals. Merge without waiting for renewed approval.

Updates the specification

4e4ced3

matsduf added the A-TestCase Area: Test case specification or implementation of test case label Aug 25, 2023

matsduf added this to the v2023.2 milestone Aug 25, 2023

matsduf requested review from a user, hannaeko, marc-vanderwal, mattias-p and tgreenx August 25, 2023 18:28

tgreenx reviewed Aug 29, 2023

View reviewed changes

matsduf added 3 commits August 30, 2023 12:00

Changes the INFO message to be outputted even if other message has be…

1ac9314

…en outputted

Resorts the link list

6b9ae07

Updates to make the name server with error to be outputted per query …

b1f11ea

…name

matsduf requested a review from tgreenx August 30, 2023 10:14

tgreenx reviewed Aug 31, 2023

View reviewed changes

tgreenx mentioned this pull request Aug 31, 2023

Disable blacklisting for queries by NAMESERVER15 zonemaster/zonemaster-engine#1285

Merged

Apply suggestions from document review

c527372

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

marc-vanderwal previously approved these changes Sep 14, 2023

View reviewed changes

tgreenx previously approved these changes Sep 14, 2023

View reviewed changes

Updates NAMESERVER15

14c3aff

* Adds test for class on the TXT records * Remove check of owner name of TXT records * Editorial update

matsduf dismissed stale reviews from tgreenx and marc-vanderwal via 14c3aff September 15, 2023 10:32

matsduf mentioned this pull request Sep 15, 2023

Nameserver15 may use TXT records of wrong class when processing response to CH TXT queries #1208

Closed

matsduf requested review from marc-vanderwal and tgreenx September 15, 2023 10:36

marc-vanderwal reviewed Sep 18, 2023

View reviewed changes

Comment thread docs/public/specifications/tests/Nameserver-TP/nameserver15.md

tgreenx reviewed Oct 12, 2023

View reviewed changes

Comment thread docs/public/specifications/tests/Nameserver-TP/nameserver15.md Outdated

Comment thread docs/public/specifications/tests/Nameserver-TP/nameserver15.md

Apply suggestions from document review

fc66547

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

matsduf requested a review from tgreenx October 16, 2023 15:57

matsduf requested a review from marc-vanderwal October 16, 2023 15:57

tgreenx previously approved these changes Oct 18, 2023

View reviewed changes

marc-vanderwal previously approved these changes Oct 19, 2023

View reviewed changes

matsduf mentioned this pull request Oct 19, 2023

Specification of test zones and test zones for NAMESERVER15 #1217

Merged

Adds specification that removes leading or trailing space characters …

d016fb2

…from version string

matsduf dismissed stale reviews from marc-vanderwal and tgreenx via d016fb2 October 27, 2023 13:17

matsduf requested review from marc-vanderwal and tgreenx October 27, 2023 13:19

marc-vanderwal previously approved these changes Oct 30, 2023

View reviewed changes

tgreenx previously approved these changes Oct 30, 2023

View reviewed changes

tgreenx added a commit to tgreenx/zonemaster-engine that referenced this pull request Nov 16, 2023

Update implementation of Nameserver15

f4af7a2

Follows test specification update (zonemaster/zonemaster#1199). Unit tests and data are also updated, based on zonemaster/zonemaster#1217.

tgreenx mentioned this pull request Nov 16, 2023

Update implementation of Nameserver15 zonemaster/zonemaster-engine#1306

Merged

Merge branch 'develop' into update-nameserver15

8996345

matsduf dismissed stale reviews from tgreenx and marc-vanderwal via 8996345 November 19, 2023 22:44

matsduf merged commit 323281e into zonemaster:develop Nov 19, 2023

matsduf deleted the update-nameserver15 branch November 19, 2023 22:45

tgreenx linked an issue Dec 5, 2023 that may be closed by this pull request

Nameserver15 may use TXT records of wrong class when processing response to CH TXT queries #1208

Closed

Uh oh!

Conversation

matsduf commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Context

Changes

How to test this PR

Uh oh!

matsduf commented Aug 25, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matsduf commented Sep 15, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matsduf commented Oct 18, 2023

Uh oh!

marc-vanderwal left a comment

Choose a reason for hiding this comment

Uh oh!

matsduf commented Oct 19, 2023

Uh oh!

matsduf commented Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matsduf commented Oct 27, 2023

Uh oh!

matsduf commented Oct 30, 2023

Uh oh!

tgreenx commented Oct 30, 2023

Uh oh!

matsduf commented Nov 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

matsduf commented Aug 25, 2023 •

edited

Loading

matsduf commented Oct 27, 2023 •

edited

Loading