Disable blacklisting for queries by NAMESERVER15#1285
Merged
Conversation
Some DNS operate autoritative DNS servers in environments that drop queries performed by the NAMESERVER15 test case, i.e. version.bind/CH/TXT and version.server/CH/TXT. In those setups, the name servers in question could be mistakenly deemed unresponsive, causing subsequent queries not to be attempted at all. This leads to false warnings in other test cases. This commit disables the blacklisting of name servers that do not respond to our version probes, preventing false warnings from being emitted.
Contributor
|
@marc-vanderwal The specification of Nameserver15 is currently being updated. See zonemaster/zonemaster#1199. I propose that we wait for the implementation update and include your proposed change then. |
Contributor
Author
|
It depends on whether we want to include this fix in the upcoming fix release. I think it could be nice if it were; if we can’t, I can wait. |
Contributor
|
I think we should have a broader solution instead of just fixing NAMESERVER15. If this is seen as a work-around waiting for the broader solution, it could be fine. |
tgreenx
approved these changes
Sep 7, 2023
matsduf
approved these changes
Sep 7, 2023
ghost
approved these changes
Sep 7, 2023
ghost
left a comment
There was a problem hiding this comment.
I've done some quick tests and this looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Some DNS operate autoritative DNS servers in environments that drop queries performed by the NAMESERVER15 test case, i.e.
version.bind/CH/TXTandversion.server/CH/TXT.In those setups, the name servers in question could be mistakenly deemed unresponsive, causing subsequent queries not to be attempted at all. This leads to false warnings in other test cases.
This commit disables the blacklisting of name servers that do not respond to our version probes, preventing false warnings from being emitted.
Context
Fixes #1281 (or at least, the situation leading to the creation of the issue).
Changes
Disable blacklisting of name servers not responding to
version.{bind,server}/CH/TXTqueries.How to test this PR
Before:
After: