Test specification template#971
Merged
matsduf merged 11 commits intoSep 20, 2021
Merged
Conversation
hannaeko
reviewed
Jul 12, 2021
matsduf
commented
Jul 13, 2021
hannaeko
reviewed
Jul 13, 2021
Contributor
Author
|
@blacksponge, please review again. |
hannaeko
previously approved these changes
Jul 20, 2021
matsduf
added a commit
to matsduf/zonemaster
that referenced
this pull request
Jul 22, 2021
* Rearranged to conform to the draft template (PR zonemaster#971). * The test procedure has been updated to not output a message for every name server matching a criteria, but for the whole group of such servers. * Removed messages that would duplicate other test cases.
matsduf
added a commit
to matsduf/zonemaster
that referenced
this pull request
Jul 22, 2021
* Rearranged to conform to the draft template (PR zonemaster#971). * The test procedure has been updated to not output a message for every name server matching a criteria, but for the whole group of such servers. * Removed messages that would duplicate other test cases.
This was referenced Jul 22, 2021
Merged
Merged
Merged
Merged
ghost
reviewed
Jul 27, 2021
ghost
left a comment
There was a problem hiding this comment.
I find it nice to have an explanation on the specification template.
Comment on lines
+76
to
+77
| > > first column, the default severity level in the second, and a statement on | ||
| > > when the message is outputted in the third. Always use the same table set-up, |
There was a problem hiding this comment.
and a statement on when the message is outputted in the third
If I don't get it wrong, this is the 4th column (not the third). Maybe you could also add something about the third column as well.
Contributor
Author
There was a problem hiding this comment.
When the text was written the now third column was not there. It was added afterwards. Fixed.
Merged
matsduf
added a commit
to matsduf/zonemaster
that referenced
this pull request
Jul 28, 2021
* Adapts to draft template (zonemaster#971) * Messages are updated. * Informational messages removed to keep down the amount of messages.
matsduf
added a commit
to matsduf/zonemaster
that referenced
this pull request
Jul 28, 2021
* Adapts to draft template (zonemaster#971) * Messages are updated. * Informational messages removed to keep down the amount of messages.
matsduf
added a commit
to matsduf/zonemaster
that referenced
this pull request
Jul 28, 2021
* Adapts to draft template (zonemaster#971) * Messages are updated. * Informational messages removed to keep down the amount of messages.
Contributor
Author
|
@blacksponge and @PNAX, please re-review after my fixes. |
ghost
reviewed
Jul 29, 2021
ghost
previously approved these changes
Jul 29, 2021
ghost
reviewed
Jul 29, 2021
ghost
previously approved these changes
Aug 2, 2021
mattias-p
previously approved these changes
Aug 17, 2021
mattias-p
left a comment
Member
There was a problem hiding this comment.
This looks good. I have attached a few suggestions.
Contributor
Author
|
@mattias-p and @PNAX, can you re-review? I did some smaller updates based on comments by @mattias-p. |
mattias-p
previously approved these changes
Sep 20, 2021
mattias-p
left a comment
Member
There was a problem hiding this comment.
I found a spelling error. Apart from that I think this is good enough.
|
|
||
| The test level abbreviation is always as follows: | ||
|
|
||
| Test level name | Example Test case ID | Abreviation | Prefix | Example message tag |
Contributor
Author
There was a problem hiding this comment.
Fixed. You have re-approve.
Contributor
Author
|
@PNAX, are you fine with this PR? Can you review and possibly approve? |
mattias-p
approved these changes
Sep 20, 2021
ghost
approved these changes
Sep 20, 2021
tgreenx
pushed a commit
to tgreenx/zonemaster
that referenced
this pull request
Jan 3, 2022
…er-engine-970 - Fixes Output issue
matsduf
added a commit
to matsduf/zonemaster
that referenced
this pull request
Jul 15, 2022
* Adapts to draft template (zonemaster#971) * Messages are updated. * Informational messages removed to keep down the amount of messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The test case specifications have evolved over the years, and different specifications have different layouts. Originally, the test message tags were not included, then they were added and then moved. The layout has changed gradually, and not always consistently since the only template available has been a recently updated or created specification.
Changes
This PR adds two specifications and one template. The specifications are of "Message Tag" and "Test Case Identifier", respectively. The template is for a test case specification, and is dependent on the twp specifications.
The template should not be considered to be The Final Template, and should be updated when needed.
How to test this PR
This documentation only, and no testing is relevant.