Updated test case Zone09 by matsduf · Pull Request #870 · zonemaster/zonemaster

matsduf · 2020-07-04T15:03:58Z

Re-written test case Zone09

Added exception for root zone, TLDs and zones under .ARPA to be required (expected) to have MX.
Updated the steps to be explicit.
Updated the steps to cover all name servers for the zone.
Added explicit messages.
Ignored address records (A/AAAA) from being mail domain target.
Considered "Null MX"
Assumes that Basic04 is run and disregard basic name server problems.

This PR will resolve issue #841 and include some validation of "Null MX" (issue #754).

Further updates:

Adapts to draft template (Test specification template #971)
Messages are updated.
Informational messages removed to keep down the amount of messages.

When this update has been merged, the implementation must also be updated.

Updates 2022-07-15

The PR was rebased on latest develop branch. All commits before 12085c1 are the same changes that were done 2022-01-17 and earlier.

Added updates:

Adds reference to "Query and responds defaults".
Updates the message tags to make them shorter.
Updates the message tag table to make it follow proposed
updates to the specification template.
- Adds message ID
- Adds arguments to message ID
Editorial updates.

cgsecurity · 2020-07-05T08:44:53Z

Should Z09_ARPA_MAIL_DOMAIN_NOT_REQUIRED and Z09_TLD_MAIL_DOMAIN_NOT_REQUIRED be INFO or WARNING ?

Maybe tests should be added to report Z09_NULL_MX_FOUND_WITH_NON_ZERO_PREFERENCE, Z09_NULL_MX_FOUND_WITH_OTHER_MX.

matsduf · 2020-07-06T07:32:13Z

Should Z09_ARPA_MAIL_DOMAIN_NOT_REQUIRED and Z09_TLD_MAIL_DOMAIN_NOT_REQUIRED be INFO or WARNING ?

INFO. They are outputted if an ARPA domain or TLD, respectively, has no MX or an Null MX, which should be considered to be normal.

Maybe tests should be added to report Z09_NULL_MX_FOUND_WITH_NON_ZERO_PREFERENCE, Z09_NULL_MX_FOUND_WITH_OTHER_MX.

Good proposal. I will add that.

cgsecurity · 2020-07-06T08:55:18Z

Should a warning be emitted if an arpa domain or TLD has an MX (except NULL_MX) ?

In my opinion, Z09_NULL_MX_WITH_NON_ZERO_PREFERENCE and Z09_NULL_MX_WITH_OTHER_MX should be WARNING
"To indicate that a domain does not accept email, it advertises a
single MX RR (see Section 3.3.9 of [RFC1035]) with an RDATA section
consisting of preference number 0 and a zero-length label, written in
master files as ".", as the exchange domain, to denote that there
exists no mail exchanger for a domain."

matsduf · 2020-07-06T10:19:17Z

Should a warning be emitted if an arpa domain or TLD has an MX (except NULL_MX) ?

I think a WARNING or even NOTICE would definitely be too strong. I cannot see that an MX there would create a problem. See Severity Level Definitions. I noticed that .ax has an MX.

According to RFC 5321 a TLD can be used as mail domain, and then it should be OK to have MX.

In my opinion, Z09_NULL_MX_WITH_NON_ZERO_PREFERENCE and Z09_NULL_MX_WITH_OTHER_MX should be WARNING
"To indicate that a domain does not accept email, it advertises a
single MX RR (see Section 3.3.9 of [RFC1035]) with an RDATA section
consisting of preference number 0 and a zero-length label, written in
master files as ".", as the exchange domain, to denote that there
exists no mail exchanger for a domain."

I cannot see that non-zero preference could create such a problem. A second MX could possibly fool a non-compliant SMTP client (i.e. a client that does not understand "Null MX") into sending the mail to the secondary MX. I will raise the second to WARNING.

matsduf · 2020-07-07T09:45:49Z

I found, or was sent, a reference on using dotless domains as mail domains, "Dotless Domains Considered Harmful". I will update the specification with a message on level WARNING if a TLD has an non-Null MX.

matsduf · 2020-07-17T20:26:20Z

@vlevigneron, any comment on this PR before I merge?

mattias-p

This rewrite is quite an expansion! All in all it looks very good. I have a few suggestions.

ghost

Just few typos, suggestions and a question.

* Adapts to draft template (zonemaster#971) * Messages are updated. * Informational messages removed to keep down the amount of messages.

* Adds reference to "Query and responds defaults". * Updates the message tags to make them shorter. * Updates the message tag table to make it follow proposed updates to the specification template. * Adds message ID * Adds arguments to message ID * Editorial updates.

matsduf · 2022-07-20T09:43:08Z

@PNAX, please re-review.

ghost

Just one last comment, otherwise this is good to me

ghost · 2022-07-27T15:24:02Z

+      1. *Child Zone* is the root zone ("."), or
+      1. *Child Zone* is a [TLD], or
+      2. *Child Zone* is a zone in the .ARPA tree.
+


I realize we are not outputting the list of found MX records at the end of this test anymore. This would be nice to list all found MX as NOTICE as before. This can be of value to know how the domain is configured to handle mails.

matsduf added the A-TestCase Area: Test case specification or implementation of test case label Jul 4, 2020

matsduf added this to the v2020.1 milestone Jul 4, 2020

matsduf requested review from mattias-p, sandoche2k and vlevigneron July 4, 2020 15:03

This was referenced Jul 4, 2020

Add test for Null MX records (RFC 7505) #754

Closed

zone09 check for .in-addr.arpa and .ip6.arpa #841

Closed

matsduf linked an issue Jul 4, 2020 that may be closed by this pull request

zone09 check for .in-addr.arpa and .ip6.arpa #841

Closed

matsduf force-pushed the update-zone09 branch 2 times, most recently from 1d5024f to d4532a1 Compare July 8, 2020 09:02

sandoche2k previously approved these changes Jul 17, 2020

View reviewed changes

mattias-p reviewed Aug 21, 2020

View reviewed changes

matsduf modified the milestones: v2020.1, v2020.2 Sep 14, 2020

matsduf modified the milestones: v2020.2, v2021.1 Mar 15, 2021

matsduf modified the milestones: v2021.1, v2021.2 May 27, 2021

matsduf dismissed sandoche2k’s stale review via a784369 July 28, 2021 13:26

matsduf force-pushed the update-zone09 branch 3 times, most recently from 0f64ef2 to 2eab47d Compare July 28, 2021 13:45

ghost reviewed Jul 29, 2021

View reviewed changes

Comment thread docs/specifications/tests/Zone-TP/zone09.md Outdated

Comment thread docs/specifications/tests/Zone-TP/zone09.md

matsduf added 10 commits July 15, 2022 16:20

Updated tests on TLD zones.

c07c3b9

Editorial updates

8a59bdc

Updates Zone09

6ac4c15

* Adapts to draft template (zonemaster#971) * Messages are updated. * Informational messages removed to keep down the amount of messages.

Adds no logical changes, just editorial changes and correction of typos

43cafc6

Fixes typos.

b6a4781

Fixes typo

21127e4

Adds editorial updates but no change in logic

e2bcf8b

Editorial updates

cd7126a

Editorial updates

2c3ca67

Updates Zone09

12085c1

* Adds reference to "Query and responds defaults". * Updates the message tags to make them shorter. * Updates the message tag table to make it follow proposed updates to the specification template. * Adds message ID * Adds arguments to message ID * Editorial updates.

matsduf force-pushed the update-zone09 branch from 681331a to 12085c1 Compare July 15, 2022 14:24

matsduf requested review from tgreenx and removed request for sandoche2k and vlevigneron July 15, 2022 14:26

ghost reviewed Jul 19, 2022

View reviewed changes

Editorial updates

5a2524d

matsduf requested a review from a user July 19, 2022 14:42

Splits message into two

5ccb3d1

ghost previously approved these changes Jul 20, 2022

View reviewed changes

Comment thread docs/specifications/tests/Zone-TP/zone09.md Outdated

Editorial update

155f654

matsduf dismissed ghost ’s stale review via 155f654 July 20, 2022 11:38

ghost approved these changes Jul 20, 2022

View reviewed changes

tgreenx approved these changes Jul 21, 2022

View reviewed changes

matsduf merged commit 1de3d06 into zonemaster:develop Jul 21, 2022

matsduf deleted the update-zone09 branch July 21, 2022 10:16

matsduf mentioned this pull request Jul 21, 2022

Implement updated zone09 zonemaster/zonemaster-engine#1103

Closed

tgreenx mentioned this pull request Jul 27, 2022

Update implementation Zone09 zonemaster/zonemaster-engine#1109

Merged

ghost reviewed Jul 27, 2022

View reviewed changes

ghost mentioned this pull request Jul 28, 2022

Test case Zone09: always output found MX records on success #1089

Merged

Uh oh!

Conversation

matsduf commented Jul 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cgsecurity commented Jul 5, 2020

Uh oh!

matsduf commented Jul 6, 2020

Uh oh!

cgsecurity commented Jul 6, 2020

Uh oh!

matsduf commented Jul 6, 2020

Uh oh!

matsduf commented Jul 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matsduf commented Jul 17, 2020

Uh oh!

mattias-p left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost left a comment • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matsduf commented Jul 20, 2022

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ghost Jul 27, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

matsduf commented Jul 4, 2020 •

edited

Loading

matsduf commented Jul 7, 2020 •

edited

Loading

ghost left a comment •

edited by ghost

Loading