Skip to content

Creates scenarios for DNSSEC01#1413

Merged
tgreenx merged 13 commits into
zonemaster:developfrom
matsduf:create-test-scenarios-dnssec01
Nov 14, 2025
Merged

Creates scenarios for DNSSEC01#1413
tgreenx merged 13 commits into
zonemaster:developfrom
matsduf:create-test-scenarios-dnssec01

Conversation

@matsduf

@matsduf matsduf commented Jul 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Purpose

This PR creates test scenarios for DNSSEC01 as updated by #1412.

This PR is complete now besides that the file test-zones-output.md can only be completed after the implementation has been done. In that file, however, there is already undelegated data and undelegated DS for scenarios that require it.

How to test this PR

All scenarios must pass.

@matsduf matsduf added the A-TestCase Area: Test case specification or implementation of test case label Jul 18, 2025
@matsduf matsduf marked this pull request as draft July 18, 2025 15:23
@matsduf matsduf mentioned this pull request Jul 18, 2025
Merged
@matsduf matsduf added this to the v2025.2 milestone Jul 18, 2025
@matsduf matsduf added the RC-None Release category: Not to be included in Changes file. label Aug 10, 2025
matsduf added 2 commits August 22, 2025 17:44
@matsduf
Adds two more scenarios. Plus editorial updates.
52d9936
@matsduf
Test scenarios for DNSSEC01:
9a15458 
* Updates to the test scenarios
* Addes test zones
* Updates address plan
@matsduf matsduf marked this pull request as ready for review September 3, 2025 16:23
@matsduf matsduf force-pushed the create-test-scenarios-dnssec01 branch from f602d0b to 7d25cf2 Compare October 8, 2025 09:58
tgreenx
tgreenx reviewed Oct 21, 2025
View reviewed changes
Comment thread docs/public/specifications/test-zones/DNSSEC-TP/dnssec01.md Outdated
Comment thread test-zone-data/DNSSEC-TP/dnssec01/CHILD.dnssec01.xa.zone Outdated
Comment thread test-zone-data/DNSSEC-TP/dnssec01/README.md Outdated
Comment thread docs/public/specifications/test-zones/DNSSEC-TP/dnssec01.md Outdated
Comment thread docs/public/specifications/test-zones/DNSSEC-TP/dnssec01.md Outdated
Comment thread docs/public/specifications/test-zones/DNSSEC-TP/dnssec01.md Outdated
Comment thread docs/public/specifications/test-zones/DNSSEC-TP/dnssec01.md
tgreenx
tgreenx reviewed Oct 21, 2025
View reviewed changes
Comment thread docs/public/specifications/test-zones/DNSSEC-TP/dnssec01.md
Comment thread docs/public/specifications/test-zones/DNSSEC-TP/dnssec01.md
Comment thread docs/public/specifications/test-zones/DNSSEC-TP/dnssec01.md Outdated
matsduf and others added 6 commits October 22, 2025 23:23
@matsduf @tgreenx
Apply suggestion from @tgreenx
b895a5a 
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
@matsduf @tgreenx
Apply suggestion from @tgreenx
7e2310c 
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
@matsduf @tgreenx
Apply suggestion from @tgreenx
b1b4827 
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
@matsduf @tgreenx
Apply suggestion from @tgreenx
c26391b 
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
@matsduf @tgreenx
Apply suggestion from @tgreenx
0592ac8 
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
@matsduf
Correced after review comment
8bde692
@matsduf matsduf requested a review from tgreenx October 23, 2025 05:56
tgreenx
tgreenx reviewed Oct 28, 2025
View reviewed changes
Comment thread test-zone-data/DNSSEC-TP/dnssec01/test-zones-output.md Outdated
Comment thread test-zone-data/DNSSEC-TP/dnssec01/test-zones-output.md
@tgreenx tgreenx mentioned this pull request Oct 28, 2025
Merged
@tgreenx

tgreenx commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

Implementation in zonemaster/zonemaster-engine#1474.

@matsduf matsduf requested a review from tgreenx October 29, 2025 08:44
@matsduf

matsduf commented Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

I see no need of update of the scenarios.

tgreenx
tgreenx previously approved these changes Oct 30, 2025
View reviewed changes

@tgreenx tgreenx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no need of update of the scenarios.

Yes, with updated test case specification, this is now fine.

@matsduf matsduf requested a review from tgreenx November 2, 2025 16:11
tgreenx
tgreenx reviewed Nov 4, 2025
View reviewed changes
Comment thread test-zone-data/DNSSEC-TP/dnssec01/test-zones-output.md Outdated
@matsduf matsduf requested a review from tgreenx November 4, 2025 16:03
@matsduf

matsduf commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

@tgreenx, please re-review.

tgreenx
tgreenx previously approved these changes Nov 4, 2025
View reviewed changes
@matsduf

matsduf commented Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

@tgreenx, I just resolved a conflict after merging #1432. Please reapprove.

@tgreenx tgreenx merged commit a863572 into zonemaster:develop Nov 14, 2025
@matsduf matsduf deleted the create-test-scenarios-dnssec01 branch November 14, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgreenx tgreenx tgreenx approved these changes
@mattias-p mattias-p Awaiting requested review from mattias-p
@tolvmannen tolvmannen Awaiting requested review from tolvmannen
@marc-vanderwal marc-vanderwal Awaiting requested review from marc-vanderwal
@MichaelTimbert MichaelTimbert Awaiting requested review from MichaelTimbert

Assignees

No one assigned

Labels

A-TestCase Area: Test case specification or implementation of test case RC-None Release category: Not to be included in Changes file.

Projects

None yet

Milestone

v2025.2

Development

Successfully merging this pull request may close these issues.

2 participants

@matsduf @tgreenx