Updates the test case specification for DNSSEC01#1412
Merged
matsduf merged 17 commits intoNov 13, 2025
Conversation
* Includse explicit msgid. * Matches current template. * New algorithms from IANA included. * Removes check if the installation handles the algorithm. That is already done in DNSSEC02 and can be elaborated there. * Always outputs some message for all tested zones.
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
* Splits a test tag into two to make it less complex. * Some updates to clarify and make less complex.
…_ip_list", which is a list of name servers by IP address
7164413 to
3b5b2e9
Compare
tgreenx
reviewed
Oct 21, 2025
Comment on lines
+97
to
+110
| | Message Tag | Level | Arguments | Message ID for message tag | | ||
| |:-------------------------|:--------|:-----------------------------------------------|:---------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | DS01_DS_ALGO_2_MISSING | NOTICE | ns_ip_list, keytag | There is a DS record with keytag {keytag}. A DS record using digest algorithm 2 (SHA-256) is missing. Fetched from parent name servers (IP) "{ns_ip_list}". | | ||
| | DS01_DS_ALGO_DEPRECATED | ERROR | ns_ip_list, keytag, ds_algo_num, ds_algo_descr | The DS record with keytag {keytag} uses a deprecated digest algorithm {ds_algo_num} ({ds_algo_descr}). Fetched from parent name servers (IP) "{ns_ip_list}". | | ||
| | DS01_DS_ALGO_NOT_DS | ERROR | ns_ip_list, keytag, ds_algo_num, ds_algo_descr | The DS record with keytag {keytag} uses a digest algorithm {ds_algo_num} ({ds_algo_descr}) not meant for DS records. Fetched from parent name servers (IP) "{ns_ip_list}". | | ||
| | DS01_DS_ALGO_OK | INFO | ns_ip_list, keytag, ds_algo_num, ds_algo_descr | The DS record with keytag {keytag} uses digest algorithm {ds_algo_num} ({ds_algo_descr}), which is OK. Fetch from parent name servers (IP) "{ns_ip_list}". | | ||
| | DS01_DS_ALGO_PRIVATE | ERROR | ns_ip_list, keytag, ds_algo_num | The DS record with keytag {keytag} uses a digest algorithm {ds_algo_num} for private use. parent name servers (IP) "{ns_ip_list}". | | ||
| | DS01_DS_ALGO_RESERVED | ERROR | ns_ip_list, keytag, ds_algo_num | The DS record with keytag {keytag} uses a reserved digest algorithm {ds_algo_num} on name servers (IP) "{ns_ip_list}". | | ||
| | DS01_DS_ALGO_UNASSIGNED | ERROR | ns_ip_list, keytag, ds_algo_num | The DS record with keytag {keytag} uses a unassigned digest algorithm {ds_algo_num} on parent name servers (IP) "{ns_ip_list}". | | ||
| | DS01_NO_RESPONSE | WARNING | ns_ip_list | No response or error in response from all parent name servers on the DS query. Name servers are "{ns_ip_list}". | | ||
| | DS01_PARENT_SERVER_NO_DS | ERROR | ns_ip_list | The following name servers do not provide DS record or have not been properly configured. Fetched from parent name servers (IP) "{ns_ip_list}". | | ||
| | DS01_PARENT_ZONE_NO_DS | NOTICE | ns_ip_list | The parent zone provides no DS records for the child zone. Fetched from parent name servers (IP) "{ns_ip_list}". | | ||
| | DS01_ROOT_N_NO_UNDEL_DS | INFO | | Tested zone is the root zone, but no undelegated DS has been provided. DS is not tested. | | ||
| | DS01_UNDEL_N_NO_UNDEL_DS | INFO | | Tested zone is undelegated, but no undelegated DS has been provided. DS is not tested. | |
Contributor
There was a problem hiding this comment.
I suggest that every "(IP)" string are removed from message ids in this table. It's a change that doesn't add anything, imho.
Contributor
Author
There was a problem hiding this comment.
When #1418 has been merged we can change from ns_ip_list to ns_list.
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Contributor
Author
tgreenx
reviewed
Oct 28, 2025
tgreenx
reviewed
Oct 28, 2025
Contributor
|
Implementation in zonemaster/zonemaster-engine#1474. |
tgreenx
reviewed
Oct 30, 2025
tgreenx
approved these changes
Oct 30, 2025
marc-vanderwal
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test scenarios are created in #1413.
When (if) #1418 is merged this PR is updated accordingly. All
ns_ip_listarguments will be replaced byns_listarguments. That change will not affect the logic.This PR requires implementation.
How to test this PR
Review.