Adds test scenarios for Basic02#1380
Conversation
* Makes set-ip.sh run much faster. Required now to be run by explicit sudo. * Requires start-coredns.sh to be run by explicit sudo to be consistent. * Updates documentation in README.md.
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
| * ns1.good-undel-4.basic02.xb | ||
| * ns2.good-undel-4.basic02.xb |
There was a problem hiding this comment.
I think?
| * ns1.good-undel-4.basic02.xb | |
| * ns2.good-undel-4.basic02.xb | |
| * ns3.good-undel-4.basic02.xb | |
| * ns4.good-undel-4.basic02.xb |
There was a problem hiding this comment.
No. Why do you think so?
There was a problem hiding this comment.
They are in a different TLD, xb instead of xa. It’s easy to miss without very careful reading, though.
There was a problem hiding this comment.
There is nothing incorrect in the naming. It is stated that the names are OOB, which means that reading as ".xa" gives an impossible name. Another name is possible (e.g. "dns1" and "dns2") but a change requires update in several files and also in another PR.
Is it requested that I do that?
There was a problem hiding this comment.
Compare with the previous scenario (GOOD-UNDEL-3) which should be roughly similar in setup. And see file test-zone-data/Basic-TP/basic02/good-undel-4.basic02.xa.zone where ns{3, 4}.good-undel-4.basic02.xb. are listed as zone NS.
There was a problem hiding this comment.
To keep down confusion I use 127.12.2.31 for ns1 and 127.12.2.33 for ns3.
I do not see why ns3/ns4 makes anything clearer. You have to check the configuration for each scenario. Such a change will require in several places in two PRs.
I will correct the zone file.
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
|
@tgreenx and @marc-vanderwal, please rereview. |
| * ns1.good-undel-4.basic02.xb | ||
| * ns2.good-undel-4.basic02.xb |
There was a problem hiding this comment.
Compare with the previous scenario (GOOD-UNDEL-3) which should be roughly similar in setup. And see file test-zone-data/Basic-TP/basic02/good-undel-4.basic02.xa.zone where ns{3, 4}.good-undel-4.basic02.xb. are listed as zone NS.
|
@tgreenx and @marc-vanderwal, you have approved zonemaster/zonemaster-engine#1447. Can this PR also be approved? |
Purpose
This PR adds test scenarios for Basic02.
The way IP addresses are loaded have changed to be much faster.
Context
These scenarios will be implemented as unit tests in Engine, see zonemaster/zonemaster-engine#1447
How to test this PR