Skip to content

Remove Nameserver14 test case#1300

Merged
tgreenx merged 2 commits into
zonemaster:developfrom
tgreenx:remove-nameserver14
Oct 23, 2024
Merged

Remove Nameserver14 test case#1300
tgreenx merged 2 commits into
zonemaster:developfrom
tgreenx:remove-nameserver14

Conversation

@tgreenx

@tgreenx tgreenx commented Oct 15, 2024

Copy link
Copy Markdown
Contributor

Purpose

This PR removes the Nameserver14 test case, considering that its scope is encompassed in both Nameserver10 and Nameserver11.

Context

Fixes #1091

How to test this PR

N/A. No mention of this Test Case should be present in the repository (besides for files updated at release time).

@tgreenx tgreenx added A-TestCase Area: Test case specification or implementation of test case A-Documentation Area: Documentation only. labels Oct 15, 2024
@tgreenx tgreenx added this to the v2024.2 milestone Oct 15, 2024
This was referenced Oct 15, 2024
Closed
Merged
Closed
matsduf
matsduf approved these changes Oct 17, 2024
View reviewed changes
Comment thread docs/internal/test-requirements/TestRequirements.md Outdated
Comment thread test-zone-data/address-plan.md
matsduf
matsduf requested changes Oct 17, 2024
View reviewed changes

@matsduf matsduf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.

@MichaelTimbert

MichaelTimbert commented Oct 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

There is still the reference to Nameserver14 with a broken link in the Readme.md
(docs/public/specifications/tests/Nameserver-TP/README.md)

@MichaelTimbert

MichaelTimbert commented Oct 21, 2024

Copy link
Copy Markdown
Contributor

There is still the reference to Nameserver14 with a broken link in the Readme.md of the parent directory
(docs/public/specifications/tests/README.md)

@MichaelTimbert

MichaelTimbert commented Oct 21, 2024

Copy link
Copy Markdown
Contributor

There is still the reference to Nameserver14 with a broken link in the TestRequirements.md (line 190)
(docs/internal/test-requirements/TestRequirements.md)

@matsduf

matsduf commented Oct 21, 2024

Copy link
Copy Markdown
Contributor

@MichaelTimbert, the two README files are generated at release time. See https://raw.githubusercontent.com/zonemaster/zonemaster/refs/heads/master/docs/public/specifications/tests/README.md https://raw.githubusercontent.com/zonemaster/zonemaster/refs/heads/master/docs/public/specifications/tests/Nameserver-TP/README.md

Isn't TestRequirements.md covered by this PR?

@tgreenx tgreenx requested a review from matsduf October 21, 2024 11:45
@tgreenx tgreenx merged commit 4d78450 into zonemaster:develop Oct 23, 2024
@tgreenx tgreenx deleted the remove-nameserver14 branch October 23, 2024 13:34
@tgreenx tgreenx linked an issue Dec 9, 2024 that may be closed by this pull request
Update Nameserver14 specification #1091
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matsduf matsduf matsduf approved these changes
@marc-vanderwal marc-vanderwal marc-vanderwal approved these changes
@MichaelTimbert MichaelTimbert MichaelTimbert approved these changes
@mattias-p mattias-p Awaiting requested review from mattias-p
@tolvmannen tolvmannen Awaiting requested review from tolvmannen

Assignees

No one assigned

Labels

A-Documentation Area: Documentation only. A-TestCase Area: Test case specification or implementation of test case

Projects

None yet

Milestone

v2024.2

Development

Successfully merging this pull request may close these issues.

Update Nameserver14 specification

4 participants

@tgreenx @MichaelTimbert @matsduf @marc-vanderwal