Creates test scenarios for Connectivity04#1299
Merged
matsduf merged 19 commits intoNov 12, 2024
Merged
Conversation
mattias-p
reviewed
Oct 14, 2024
mattias-p
left a comment
Member
There was a problem hiding this comment.
Looks pretty good. I didn't read thoroughly through the zone and config files.
There seemed to be some confusion around double prefixes and I did my best to straighten it out. You be the judge of how well I did.
matsduf
commented
Oct 14, 2024
matsduf
left a comment
Contributor
Author
There was a problem hiding this comment.
@mattias-p, I accepted all your suggestions, but the tool complained that you had more than one change on the same line. I will process them manually instead.
| | 127.13.4.24 | root-ns2.xa (test case local root zone) | | ||
| | 127.13.4.25 | ns1.asnlookup.zonemaster.net (test case local) | | ||
| | 127.13.4.26 | ns2.asnlookup.zonemaster.net (test case local) | | ||
| | (...) | | |
Contributor
Author
There was a problem hiding this comment.
I will check to make it consistent.
Co-authored-by: Mattias Päivärinta <mattias@paivarinta.se>
Co-authored-by: Mattias Päivärinta <mattias@paivarinta.se>
index file. That file is updated to match updated scenarios. A new README being an index is created.
mattias-p
previously approved these changes
Oct 18, 2024
mattias-p
left a comment
Member
There was a problem hiding this comment.
This looks good to me. I have a few questions/suggestions but nothing critical.
Co-authored-by: Mattias Päivärinta <mattias@paivarinta.se>
Merged
tgreenx
requested changes
Oct 22, 2024
tgreenx
reviewed
Oct 22, 2024
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
tgreenx
requested changes
Oct 22, 2024
tgreenx
reviewed
Oct 22, 2024
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Contributor
Author
|
@tgreenx, thank you for thorough review. |
tgreenx
reviewed
Oct 22, 2024
tgreenx
requested changes
Oct 22, 2024
…vity04.md Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Contributor
Author
|
Two scenarios are renamed (ERROR-PREFIX-DATABASE-4 and -5) and expected tags are updated. This update is to match the latest update of the specification. New names are HAS-NON-ASN-TXT-1 and -2. (ERROR-PREFIX-DATABASE-6, -7 and -8 are neither renamed or updated.) |
…t case specification
c48f47e to
3253a3b
Compare
tgreenx
reviewed
Oct 24, 2024
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
tgreenx
previously approved these changes
Oct 30, 2024
Contributor
Author
|
@marc-vanderwal, @MichaelTimbert, @mattias-p, please review. |
Contributor
Author
|
@tgreenx, can you approve again? I just updated the file with the output from zonemaster-cli. |
marc-vanderwal
approved these changes
Nov 6, 2024
tgreenx
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR creates test scenarios for test case Connectivity04, and test zones for those scenarios. The scenarios are based on the test case specification as updated by #1298.
In file
test-zone-data/Connectivity-TP/connectivity04/README.mdit is reported the results from testing the test zones byzonemaster-cli, but that is before the update of the implementation of the test case.zonemaster-clioutputs unexpected "Use of uninitialized value (...)".Context
#1298
How to test this PR
Review the test scenarios to verify that all relevant cases have been covered.
When the implementation of Connectivity04 has been updated (based on #1298), then rerun then commands in the README file.