Updates Connectivity04#1298
Merged
Merged
Conversation
* Adds message tag for the case where only one IP prefix is used for all nameservers with the same IP protocol. * Lowers the level when more than one name server is on the same prefix with the same IP protocol.
13cd01e to
b3eee9d
Compare
mattias-p
previously approved these changes
Oct 14, 2024
mattias-p
left a comment
Member
There was a problem hiding this comment.
Nice! Found a few minor nits.
| for examples). Do for each TXT record: | ||
| 1. If the TXT record consists of multiple strings in RDATA, then [concatenate] | ||
| the strings into one string. | ||
| 2. Using the format of such string parse the string into its parts and |
Member
There was a problem hiding this comment.
the format of such string
Is there a specification for this we could/should refer to?
Contributor
Author
There was a problem hiding this comment.
No. My plan is to go backwards no to delay this change, i.e. to write that specification afterwards.
mattias-p
previously approved these changes
Oct 14, 2024
tgreenx
reviewed
Oct 15, 2024
tgreenx
reviewed
Oct 15, 2024
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Contributor
Author
|
@tgreenx and @mattias-p: Please re-review. |
tgreenx
previously approved these changes
Oct 17, 2024
mattias-p
previously approved these changes
Oct 18, 2024
Contributor
Author
|
This PR is approved. The test zones and scenarios are complete (#1299). Next step is implementation. |
|
🙂 |
tgreenx
reviewed
Oct 22, 2024
tgreenx
previously approved these changes
Oct 23, 2024
Contributor
Author
tgreenx
reviewed
Oct 30, 2024
tgreenx
approved these changes
Oct 30, 2024
Contributor
Author
|
@marc-vanderwal, @MichaelTimbert, @mattias-p, please review. |
marc-vanderwal
approved these changes
Nov 6, 2024
This was referenced Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The test case outputs a warning if more than one name server has its IP address on the same prefix even if other name servers has IP addresses on other prefixes. This PR lower that warning to a notice. To capture the case when all name servers has IP addresses in the prefix a new message tag has been added, and that tag has a warning level.
Today the test case will not capture the case when there is a single name server. That has been fixed.
If this PR is approved, test scenarios and updated implementation must be provided.
Context
#1289, #1174
Test scenarios created by #1299
Test implementation updated by zonemaster/zonemaster-engine#1393
How to test this PR
Review.