Test scenarios for Address01#1296
Merged
Merged
Conversation
matsduf
requested changes
Oct 2, 2024
matsduf
previously requested changes
Oct 7, 2024
tgreenx
requested changes
May 14, 2025
tgreenx
reviewed
May 14, 2025
marc-vanderwal
previously approved these changes
May 21, 2025
matsduf
requested changes
May 21, 2025
Contributor
Agree. |
Co-authored-by: Mats Dufberg <mats.dufberg@iis.se>
matsduf
requested changes
Sep 12, 2025
tgreenx
reviewed
Nov 4, 2025
tgreenx
reviewed
Nov 5, 2025
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
tgreenx
previously approved these changes
Nov 6, 2025
tgreenx
reviewed
Nov 6, 2025
Contributor
There was a problem hiding this comment.
(This file should be updated before merging)
matsduf
reviewed
Nov 7, 2025
matsduf
left a comment
Contributor
There was a problem hiding this comment.
Looks fine. The test is when used as unit tests.
matsduf
previously approved these changes
Nov 7, 2025
matsduf
left a comment
Contributor
There was a problem hiding this comment.
This is fine, but test-zones-output.md should be updated before merge. @tolvmannen, install the implementation from zonemaster/zonemaster-engine#1453 and run the zonemaster-cli commands and add the output to test-zones-output.md and verify the output.
Updates "test-zones-output" after running "zonemaster-cli" with the updated code
Contributor
|
@tgreenx, I have taken over, but still on the fork of @tolvmannen |
tgreenx
approved these changes
Nov 13, 2025
| * IPv4 address NOT_GLOBALLY_REACHABLE | ||
| * IPv6 address DOCUMENTATION_ADDR | ||
|
|
||
| ### NO_NAME_SERVERS |
Contributor
There was a problem hiding this comment.
Suggested change
| ### NO_NAME_SERVERS | |
| ### NO-NAME-SERVERS |
tgreenx
requested changes
Nov 13, 2025
Comment on lines
+53
to
+65
| | Scenario name | Mandatory message tag | Forbidden message tags | | ||
| |:--------------------|:------------------------------------------------------------------------------------------------------------|:-----------------------| | ||
| | GOOD-1 | A01_GLOBALLY_REACHABLE_ADDR | 2) | | ||
| | MIXED-LOCAL-DOC-1 | A01_LOCAL_USE_ADDR, A01_DOCUMENTATION_ADDR, A01_GLOBALLY_REACHABLE_ADDR | 2) | | ||
| | MIXED-LOCAL-DOC-2 | A01_LOCAL_USE_ADDR, A01_DOCUMENTATION_ADDR, A01_GLOBALLY_REACHABLE_ADDR | 2) | | ||
| | MIXED-LOCAL-OTHER-1 | A01_LOCAL_USE_ADDR, A01_ADDR_NOT_GLOBALLY_REACHABLE, A01_GLOBALLY_REACHABLE_ADDR | 2) | | ||
| | MIXED-LOCAL-OTHER-2 | A01_LOCAL_USE_ADDR, A01_ADDR_NOT_GLOBALLY_REACHABLE, A01_GLOBALLY_REACHABLE_ADDR | 2) | | ||
| | MIXED-DOC-OTHER-1 | A01_DOCUMENTATION_ADDR, A01_ADDR_NOT_GLOBALLY_REACHABLE, A01_GLOBALLY_REACHABLE_ADDR | 2) | | ||
| | MIXED-DOC-OTHER-2 | A01_DOCUMENTATION_ADDR, A01_ADDR_NOT_GLOBALLY_REACHABLE, A01_GLOBALLY_REACHABLE_ADDR | 2) | | ||
| | MIXED-ALL-1 | A01_ADDR_NOT_GLOBALLY_REACHABLE, A01_DOCUMENTATION_ADDR, A01_LOCAL_USE_ADDR, A01_GLOBALLY_REACHABLE_ADDR | 2) | | ||
| | MIXED-ALL-2 | A01_ADDR_NOT_GLOBALLY_REACHABLE, A01_DOCUMENTATION_ADDR, A01_LOCAL_USE_ADDR, A01_GLOBALLY_REACHABLE_ADDR | 2) | | ||
| | ALL-NON-REACHABLE | A01_ADDR_NOT_GLOBALLY_REACHABLE, A01_LOCAL_USE_ADDR, A01_DOCUMENTATION_ADDR, A01_NO_GLOBALLY_REACHABLE_ADDR | 2) | | ||
| | NO_NAME_SERVERS | A01_NO_NAME_SERVERS_FOUND | 2) | |
Contributor
There was a problem hiding this comment.
I think there should be at least two more test scenarios defined :
- one that uses IP address(es) from other special categories which are not globally reachable (e.g. "Deprecated" or "Benchmarking") -> e.g.
OTHER-BUT-NOT-REACHABLEorMIXED-OTHER-NOT-REACHABLE - and one that uses IP address(es) from other special categories which are globally reachable (e.g. "Direct Delegation AS112 Service" or "AMT" or "Port Control Protocol Anycast")-> e.g
OTHER-BUT-REACHABLEorMIXED-OTHER-REACHABLE
Contributor
|
@tgreenx, updated with globally reachable addresses from special registries. All scenarios pass. Log updated. Please review. |
tgreenx
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adding test zone(s) for updated test case address01 (#1284)